Skip to content

Commit e410c97

Browse files
authored
refactor: 오늘의 리뷰 개수를 3개에서 2개로 변경 (#50)
1 parent 0824d5b commit e410c97

3 files changed

Lines changed: 10 additions & 14 deletions

File tree

src/main/java/com/funeat/review/application/ReviewService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public class ReviewService {
6060
private static final int START_INDEX = 0;
6161
private static final int ONE = 1;
6262
private static final String EMPTY_URL = "";
63-
private static final int RANKING_SIZE = 3;
63+
private static final int RANKING_SIZE = 2;
6464
private static final long RANKING_MINIMUM_FAVORITE_COUNT = 1L;
6565
private static final int REVIEW_PAGE_SIZE = 10;
6666

src/test/java/com/funeat/acceptance/review/ReviewAcceptanceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ class getRankingReviews_성공_테스트 {
737737

738738
// then
739739
STATUS_CODE를_검증한다(응답, 정상_처리);
740-
리뷰_랭킹_조회_결과를_검증한다(응답, List.of(리뷰2, 리뷰3, 리뷰4));
740+
리뷰_랭킹_조회_결과를_검증한다(응답, List.of(리뷰2, 리뷰3));
741741
}
742742
}
743743

src/test/java/com/funeat/review/application/ReviewServiceTest.java

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,7 @@ class 리뷰_개수에_대한_테스트 {
12171217
}
12181218

12191219
@Test
1220-
void 전체_리뷰가_1개_이상_3개_미만이라도_리뷰가_나와야한다() {
1220+
void 전체_리뷰가_1개라도_리뷰가_나와야한다() {
12211221
// given
12221222
final var category = 카테고리_간편식사_생성();
12231223
단일_카테고리_저장(category);
@@ -1229,13 +1229,11 @@ class 리뷰_개수에_대한_테스트 {
12291229
단일_멤버_저장(member);
12301230

12311231
final var now = LocalDateTime.now();
1232-
final var review1 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 2L, now.minusDays(1L));
1233-
final var review2 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 2L, now);
1234-
복수_리뷰_저장(review1, review2);
1232+
final var review = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 2L, now.minusDays(1L));
1233+
단일_리뷰_저장(review);
12351234

1236-
final var rankingReviewDto1 = RankingReviewDto.toDto(review1);
1237-
final var rankingReviewDto2 = RankingReviewDto.toDto(review2);
1238-
final var rankingReviewDtos = List.of(rankingReviewDto2, rankingReviewDto1);
1235+
final var rankingReviewDto = RankingReviewDto.toDto(review);
1236+
final var rankingReviewDtos = List.of(rankingReviewDto);
12391237
final var expected = RankingReviewsResponse.toResponse(rankingReviewDtos);
12401238

12411239
// when
@@ -1247,7 +1245,7 @@ class 리뷰_개수에_대한_테스트 {
12471245
}
12481246

12491247
@Test
1250-
void 전체_리뷰_중_랭킹이_높은_상위_3개_리뷰를_구할_수_있다() {
1248+
void 전체_리뷰_중_랭킹이_높은_상위_2개_리뷰를_구할_수_있다() {
12511249
// given
12521250
final var category = 카테고리_간편식사_생성();
12531251
단일_카테고리_저장(category);
@@ -1262,14 +1260,12 @@ class 리뷰_개수에_대한_테스트 {
12621260
final var review1 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 4L, now.minusDays(3L));
12631261
final var review2 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 6L, now.minusDays(2L));
12641262
final var review3 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 4L, now);
1265-
final var review4 = 리뷰_이미지test5_평점5점_재구매X_생성(member, product, 5L, now);
1266-
복수_리뷰_저장(review1, review2, review3, review4);
1263+
복수_리뷰_저장(review1, review2, review3);
12671264

12681265
final var rankingReviewDto1 = RankingReviewDto.toDto(review1);
12691266
final var rankingReviewDto2 = RankingReviewDto.toDto(review2);
12701267
final var rankingReviewDto3 = RankingReviewDto.toDto(review3);
1271-
final var rankingReviewDto4 = RankingReviewDto.toDto(review4);
1272-
final var rankingReviewDtos = List.of(rankingReviewDto4, rankingReviewDto3, rankingReviewDto2);
1268+
final var rankingReviewDtos = List.of(rankingReviewDto3, rankingReviewDto2);
12731269
final var expected = RankingReviewsResponse.toResponse(rankingReviewDtos);
12741270

12751271
// when

0 commit comments

Comments
 (0)