Skip to content

Comment/vote issues on fyi.frontpage.* records #318

@tom-sherman

Description

@tom-sherman

When creating comments and votes in the app on posts/comments with the new lexicon there are a few issues.

The data in the record is incorrect, but somehow it still gets associated to the right post/comment. i guess it's just finding the first one, need to add collection to the foreign key.

Example of invalid record: https://atproto-browser.vercel.app/at/did:plc:2xau7wbgdq4phuou2ypwuen7/fyi.unravel.frontpage.comment/3maeymry67s2u

vote deletions need work too (maybe same applies to comments but i haven't checked). when we delete a vote we do so by did+rkey, but a user may have created a comment/vote on both lexicons. these are distinct votes/comments but both will be deleted

not a huge deal because it shouldn't happen in normal operation, but still work fixing. should be easy enough, just do the vote deletion using our internal comment/vote ID or did+collection+rkey. We already store the collection on votes and comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions