Fix combobox can't open dropdown when the editable textbox of it has the focus#1114
Merged
batzen merged 2 commits intofluentribbon:developfrom Mar 13, 2023
Merged
Fix combobox can't open dropdown when the editable textbox of it has the focus#1114batzen merged 2 commits intofluentribbon:developfrom
batzen merged 2 commits intofluentribbon:developfrom
Conversation
Member
|
Thanks for contributing! |
batzen
added a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code has detected the SelectedItem is not null, and I think it's better to detect container is not null too. Especially when the ComboBox dropdown is never open.
If the given target of the
Keyboard.Focusmethod is null, the keyboard will focus to the RootVisual like MainWindow. It causes the keyboard focus changes if the keyboard has been already focused on it. But in .NET WPF code, when the IsKeyboardFocusWithin changed, it may cause the dropdown closed immediately.