Loading firebird driver

[lsces]

fisharebest ... I'm starting clean here since the other thread was getting messy.
I now have a clean repo registered as https://packagist.org/packages/lsces/illuminate-firebird and this is working nicely with composer so at least the code is stable.
I need a little update to it as I screwed up one of the namespace entries so V2.0.1 will be out shortly.
So I am now back into the resolverFor to add firebird to the illuminate driver list. The problem is the same chicken and egg I've had to date.
if ($driver === self::FIREBIRD) { $closure = static fn ($connection, $database, $prefix, $config) => new FirebirdConnection($connection, $database, $prefix, $config); DB::resolverFor('firebird', $closure); }
Fails simply because the first thing it tries to do is LOAD a connection using illuminate but it does not have firebird in it's list :(
I'm not entirely sure what Bert was actually doing that seemed to work for him, but I am hitting the same brick wall I was previously :(

[lsces]

OK at least I'm making some progress :) v2.0.1 has just been accepted and updated nicely!
Having tried to tidy things up I'd missed that the autoload needed to pick up the src/illuminate directory.
debugging the resolverFor() path, what is missing is a Fisharebest\Webtrees\DB instance when calling FirebirdConnection so we get into the chicken and egg situation.
I'm back with hacking ConnectionFactory as it simply works :)

[BertKoor]

I do not recognise your change in the DB class of webtrees. This is my change in it:

See main...BertKoor:webtrees:issue5325_FirebirdSupport

[BertKoor]

If you don't cast the right spells, then the magic does not happen.

webtrees is not a regular illuminate app. It uses only some selected parts. Since the regular bootstrapping & configuration is not done, you have to do some things yourself.

The part of the ConnectionFactory you hacked, where switches based on driver... Right above that is the mechanism for other drivers. Like yours.

So I have registered with the illuminate container how it can obtain a new instance of a connector and connection for your firebird driver.

[lsces]

THANK YOU BertKoor ... now the magic works ;)
Part of my problem was not being able to actually load the correct software for the driver and now that has been sorted everything else drops into place!
Another mistake was that I was still missing a use statement for Connection:: and more important for me I now understand better how to isolate the illuminate stuff from the application stuff ;)
ps I did drop the extra $capsule = new self(); and the committed change is working fine.

[lsces]

fisharebest
I took the tidy step of wiping my fork of webtrees and starting a clean one, so the 5 commits on lsces/webtrees have lost all of the intermediate mess. I still have a problem with running an export, and I have not ACTUALLY done a clean install yet but what is there now incorporates the bits to get my live site working and displaying cleanly.

[lsces]

OK have been achieving clean installs, but finally nailed down the problem with Migration45 ... Have commented out the foreign links on lines 52 and 53 which is still throwing an error which the trackback tags as line 44 so I had been looking at the wrong thing :(
illuminat-firebird has had another version update as there was still a namespace problem, and I have spotted a big bit of work which involves returning the column information. At least hasColumn IS now comparing lower case field names.

[lsces]

Having overridden Connection/cursor in the firebird driver gedcom export is working again - not yet issued as a new version. Another hack I'd put in illuminate and missed when tidying up :(
Will pick this up again on Monday as I have an exhibition stand to help on over the weekend ...

[fisharebest]

@lsces - FYI,

I have been working on my own database abstraction layer for schema migrations. The two popular options (doctrine/dbal and illuminate/database) both have major limitations. I've reached the first milestone - it can now create databases in MySQL/PostgreSQL/SQLite/SQLServer/Firebird from a specification. The next steps will be introspecting existing databases (in progress) and then generating updates to bring existing systems up to date (some code for this is already written).

The latest versions of illuminate/database allow us to use INSERT INTO ... RETURNING .... This is the ANSI standard, supported by all databases, except MySQL 5.7 (which still requires LAST_INSERT_ID()). I'll update the webtrees code to use this. So this will be one less thing for you to patch.

[lsces]

I'm working on making the firebird driver as generic as possible, so having to cope with LastInsertId() in PDO is a required, but it would be nice if I could be a bit more selective. The driver does not do all the bells and whistles on columns that other drivers have, and adding that is another important item, but I think I can 'borrow' much of that from ADOdb and then identifying just which is the autoincrement field that needs returning will be easier. This is starting to hang together a lot better ...