Hi,
I've found some issues regarding naming of activities (activtyType.name attribute). On the workflow side it is inferred from ActivityInterfaceClassName::method_name or you can give it a custom name by means of the name parameter of the activity_method decorator, thats all fine.
Unfortunately on the activity side (register_activities_implementation) you have very little room for setting the activityType and the two :: are always there. So consider integration with a workflow code written in Java - you have to anticipate this issue and explicitly rename the activity interface so that it fits this convention. Have you considered allowing for passing the activityType.name directly to register_activities_implementation? Or maybe it is possible to somehow make use of the name param passed via the activity_method decorator (one would expect to inherit ActivitiesImplementation from ActivitiesInterface anyway right)?
Originally posted by @Malicious1 in #6
Hi,
I've found some issues regarding naming of activities (
activtyType.nameattribute). On the workflow side it is inferred fromActivityInterfaceClassName::method_nameor you can give it a custom name by means of thenameparameter of theactivity_methoddecorator, thats all fine.Unfortunately on the activity side (
register_activities_implementation) you have very little room for setting the activityType and the two::are always there. So consider integration with a workflow code written in Java - you have to anticipate this issue and explicitly rename the activity interface so that it fits this convention. Have you considered allowing for passing the activityType.name directly toregister_activities_implementation? Or maybe it is possible to somehow make use of thenameparam passed via theactivity_methoddecorator (one would expect to inherit ActivitiesImplementation from ActivitiesInterface anyway right)?Originally posted by @Malicious1 in #6