Merge branch 'main' into update-governance-3

Author: kriswest

.github/workflows/unused-dependencies.yml

@@ -21,7 +21,7 @@ jobs:
           node-version: '24.x'
       - name: 'Run depcheck'
         run: |
-          npx depcheck --skip-missing --ignores="tsx,@babel/*,@commitlint/*,eslint,eslint-*,husky,ts-node,concurrently,nyc,prettier,typescript,tsconfig-paths,vite-tsconfig-paths,quicktype,history,@types/domutils,@vitest/coverage-v8,cross-env,c8,tailwindcss,react-is"
+          npx depcheck --skip-missing --ignores="tsx,@babel/*,@commitlint/*,eslint,eslint-*,husky,ts-node,concurrently,prettier,typescript,tsconfig-paths,vite-tsconfig-paths,quicktype,history,@types/domutils,@vitest/coverage-v8,cross-env,c8,tailwindcss,react-is"
           echo $?
           if [[ $? == 1 ]]; then
             echo "Unused dependencies or devDependencies found"

nyc.config.js

@@ -195,7 +195,6 @@
     "globals": "^17.6.0",
     "husky": "^9.1.7",
     "lint-staged": "^17.0.5",
-    "nyc": "^18.0.0",
     "prettier": "^3.8.1",
     "quicktype": "^23.2.6",
     "supertest": "^7.2.2",

package-lock.json

@@ -0,0 +1,57 @@
+/**
+ * Copyright 2026 GitProxy Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { Migration } from './index';
+
+/**
+ * Backfills dateCreated/lastModified on repos created before those fields
+ * existed. Reads through the sink, asks the backend to derive a creation time
+ * (Mongo derives it from the ObjectId; the file backend has no source and
+ * returns undefined), and writes through the sink. Repos that already have a
+ * dateCreated are skipped, so the migration is safe to re-run.
+ */
+export const populateRepoDates: Migration = {
+  id: '20260729-populate-repo-dates',
+
+  up: async (sink) => {
+    const repos = await sink.getRepos();
+    for (const repo of repos) {
+      if (repo.dateCreated || !repo._id) {
+        continue;
+      }
+      const created = sink.deriveCreatedAt(repo._id) ?? new Date().toISOString();
+      await sink.updateRepo({
+        _id: repo._id,
+        dateCreated: created,
+        lastModified: repo.lastModified ?? created,
+      });
+    }
+  },
+
+  down: async (sink) => {
+    const repos = await sink.getRepos();
+    for (const repo of repos) {
+      if (!repo._id) {
+        continue;
+      }
+      await sink.updateRepo({
+        _id: repo._id,
+        dateCreated: undefined,
+        lastModified: undefined,
+      });
+    }
+  },
+};

package.json

@@ -15,5 +15,6 @@
  */
 
 import type { Migration } from './index';
+import { populateRepoDates } from './populateRepoDates';
 
-export const migrations: Migration[] = [];
+export const migrations: Migration[] = [populateRepoDates];

src/db/migrations/populateRepoDates.ts

@@ -19,13 +19,19 @@ import { SAMPLE_REPO } from '../../src/proxy/constants';
 
 vi.mock('../../src/db/mongo', () => ({
   getRepoByUrl: vi.fn(),
+  getRepos: vi.fn().mockResolvedValue([]),
+  updateRepo: vi.fn(),
+  deriveCreatedAt: vi.fn(),
   getAppliedMigrations: vi.fn().mockResolvedValue([]),
   recordMigration: vi.fn(),
   unrecordMigration: vi.fn(),
 }));
 
 vi.mock('../../src/db/file', () => ({
   getRepoByUrl: vi.fn(),
+  getRepos: vi.fn().mockResolvedValue([]),
+  updateRepo: vi.fn(),
+  deriveCreatedAt: vi.fn(),
   getAppliedMigrations: vi.fn().mockResolvedValue([]),
   recordMigration: vi.fn(),
   unrecordMigration: vi.fn(),

src/db/migrations/registry.ts

@@ -0,0 +1,119 @@
+/**
+ * Copyright 2026 GitProxy Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { describe, it, expect, vi } from 'vitest';
+import { populateRepoDates } from '../../../src/db/migrations/populateRepoDates';
+import type { Sink } from '../../../src/db/types';
+
+type RepoRecord = Record<string, unknown> & { _id: string };
+
+const makeSink = (repos: RepoRecord[], deriveCreatedAt: (id: string) => string | undefined) => {
+  const store = new Map(repos.map((r) => [r._id, { ...r }]));
+  const updateRepo = vi.fn(async (repo: Record<string, unknown>) => {
+    const { _id, ...fields } = repo;
+    Object.assign(store.get(_id as string) as RepoRecord, fields);
+  });
+  const sink = {
+    getRepos: async () => [...store.values()],
+    updateRepo,
+    deriveCreatedAt,
+  } as unknown as Sink;
+  return { sink, updateRepo, get: (id: string) => store.get(id) };
+};
+
+describe('populateRepoDates migration', () => {
+  it('is registered under a sortable, timestamped id', () => {
+    expect(populateRepoDates.id).toBe('20260729-populate-repo-dates');
+  });
+
+  it('backfills dateCreated from the backend-derived value', async () => {
+    const { sink, get } = makeSink([{ _id: 'r1' }], () => '2020-01-01T00:00:00.000Z');
+
+    await populateRepoDates.up(sink);
+
+    expect(get('r1')?.dateCreated).toBe('2020-01-01T00:00:00.000Z');
+    expect(get('r1')?.lastModified).toBe('2020-01-01T00:00:00.000Z');
+  });
+
+  it('falls back to the run time when the backend cannot derive one', async () => {
+    // the file backend always returns undefined - NeDB ids carry no timestamp
+    const before = Date.now();
+    const { sink, get } = makeSink([{ _id: 'r1' }], () => undefined);
+
+    await populateRepoDates.up(sink);
+
+    const created = get('r1')?.dateCreated as string;
+    expect(Date.parse(created)).toBeGreaterThanOrEqual(before);
+    expect(get('r1')?.lastModified).toBe(created);
+  });
+
+  it('preserves an existing lastModified instead of overwriting it', async () => {
+    // role mutations bump lastModified on repos that never had a dateCreated
+    const { sink, get } = makeSink(
+      [{ _id: 'r1', lastModified: '2024-06-01T00:00:00.000Z' }],
+      () => '2020-01-01T00:00:00.000Z',
+    );
+
+    await populateRepoDates.up(sink);
+
+    expect(get('r1')?.dateCreated).toBe('2020-01-01T00:00:00.000Z');
+    expect(get('r1')?.lastModified).toBe('2024-06-01T00:00:00.000Z');
+  });
+
+  it('skips repos that already have a dateCreated, so it is safe to re-run', async () => {
+    const { sink, updateRepo, get } = makeSink(
+      [{ _id: 'r1', dateCreated: '2019-05-05T00:00:00.000Z' }],
+      () => '2020-01-01T00:00:00.000Z',
+    );
+
+    await populateRepoDates.up(sink);
+
+    expect(updateRepo).not.toHaveBeenCalled();
+    expect(get('r1')?.dateCreated).toBe('2019-05-05T00:00:00.000Z');
+  });
+
+  it('backfills only the repos that need it', async () => {
+    const { sink, updateRepo, get } = makeSink(
+      [{ _id: 'r1' }, { _id: 'r2', dateCreated: '2019-05-05T00:00:00.000Z' }, { _id: 'r3' }],
+      (id) => `2020-01-0${id === 'r1' ? 1 : 3}T00:00:00.000Z`,
+    );
+
+    await populateRepoDates.up(sink);
+
+    expect(updateRepo).toHaveBeenCalledTimes(2);
+    expect(get('r1')?.dateCreated).toBe('2020-01-01T00:00:00.000Z');
+    expect(get('r2')?.dateCreated).toBe('2019-05-05T00:00:00.000Z');
+    expect(get('r3')?.dateCreated).toBe('2020-01-03T00:00:00.000Z');
+  });
+
+  it('down clears both timestamps', async () => {
+    const { sink, get } = makeSink(
+      [
+        {
+          _id: 'r1',
+          dateCreated: '2020-01-01T00:00:00.000Z',
+          lastModified: '2020-01-01T00:00:00.000Z',
+        },
+      ],
+      () => undefined,
+    );
+
+    await populateRepoDates.down!(sink);
+
+    expect(get('r1')?.dateCreated).toBeUndefined();
+    expect(get('r1')?.lastModified).toBeUndefined();
+  });
+});