Skip to content

Commit 28cd632

Browse files
authored
Merge pull request #1669 from finos/bump-workflow-patch
ci: prevent skipping dev dependencies on lint.yml
2 parents f0c773d + c18649e commit 28cd632

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

.github/workflows/version-bump.yml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ on:
99
version:
1010
description: 'Version to bump to, e.g. 2.2.0'
1111
required: true
12+
env:
13+
NODE_VERSION: 22
1214

1315
permissions:
1416
contents: write
@@ -35,7 +37,7 @@ jobs:
3537
- name: Setup Node
3638
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
3739
with:
38-
node-version: '24'
40+
node-version: ${{ env.NODE_VERSION }}
3941

4042
- name: Resolve version
4143
id: version
@@ -66,16 +68,18 @@ jobs:
6668
exit 1
6769
fi
6870
69-
- name: Bump root package
70-
env:
71-
VERSION: ${{ steps.version.outputs.version }}
72-
run: npm version "$VERSION" --no-git-tag-version --allow-same-version
71+
- name: Install dependencies
72+
run: npm ci --ignore-scripts --no-audit --no-fund
7373

74-
- name: Bump git-proxy-cli package
75-
working-directory: packages/git-proxy-cli
74+
- name: Bump root and workspace packages
7675
env:
7776
VERSION: ${{ steps.version.outputs.version }}
78-
run: npm version "$VERSION" --no-git-tag-version --allow-same-version
77+
run: |
78+
npm version "$VERSION" \
79+
--no-git-tag-version \
80+
--allow-same-version \
81+
--workspaces \
82+
--include-workspace-root
7983
8084
- name: Open version bump PR
8185
env:
@@ -91,9 +95,9 @@ jobs:
9195
git config user.email "github-actions[bot]@users.noreply.github.com"
9296
9397
git checkout -b "$BRANCH"
94-
git add package.json package-lock.json packages/git-proxy-cli/package.json
98+
git add package.json package-lock.json packages/*/package.json
9599
git commit -m "chore: bump git-proxy and git-proxy-cli to $VERSION"
96-
git push -u origin "$BRANCH" --force
100+
git push -u origin "$BRANCH" --force-with-lease
97101
98102
if [ -n "$MILESTONE_URL" ]; then
99103
SOURCE_LINE="Triggered by closing milestone **$MILESTONE_TITLE** ($MILESTONE_URL)."

0 commit comments

Comments
 (0)