Skip to content

Commit 2bdf86a

Browse files
committed
Fix CI: typo lfqdata$conf -> lfqdata$config and quote bare contrast in unnest
- LFQDataImp.R: lfqdata$conf was NULL (correct field is config), causing example crash on CI where zCompositions is installed - logistf.R, tidyMS_R6_Modelling.R: quote "contrast" in unnest(cols=) to fix R CMD check NOTE about undefined global variable
1 parent 525cdcf commit 2bdf86a

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

R/LFQDataImp.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impute_with_zcomp <- function(lfqdata,
125125
lfqdata$data <- response_matrix_as_tibble(
126126
imputed_data,
127127
paste0(lfqdata$response(),"_imputed"),
128-
lfqdata$conf, lfqdata$data)
128+
lfqdata$config, lfqdata$data)
129129

130130
return(lfqdata)
131131
}

R/logistf.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ contrasts_linfct_firth <- function(models,
6060

6161
contrasts <- interaction_model_matrix |>
6262
dplyr::select(all_of(c(subject_Id, "contrast"))) |>
63-
tidyr::unnest(cols = c(contrast))
63+
tidyr::unnest(cols = c("contrast"))
6464

6565
# take sigma and df from somewhere else.
6666
modelInfos <- modelDF |>

R/tidyMS_R6_Modelling.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ contrasts_linfct <- function(models,
981981

982982
contrasts <- interaction_model_matrix |>
983983
dplyr::select(all_of(c(subject_Id, "contrast"))) |>
984-
tidyr::unnest(cols = c(contrast))
984+
tidyr::unnest(cols = c("contrast"))
985985

986986
# take sigma and df from somewhere else.
987987
modelInfos <- models |>

0 commit comments

Comments
 (0)