✨ Add Engine class re-export from SQLAlchemy#1981
Closed
AlefRP wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
Please add the |
Member
|
I think we should do it in a more complex way - add not just Let's start from discussion as it's asked in the PR template |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR re-exports SQLAlchemy's
Engineclass from the top-levelsqlmodelnamespace, alongside the already-exported
create_engine,create_mock_engineand
engine_from_config.This makes it possible to import
Enginedirectly fromsqlmodeland use itfor type hints when writing your own engine/session helpers, mirroring how
SQLAlchemy exposes it:
The export is added next to the other sqlalchemy.engine imports in
sqlmodel/init.py, following the existing import X as X re-export
convention used throughout the file (so it is picked up as public API by type
checkers and linters).
Checklist