working on cleaning up warnings when -Wconversion is enabled, there's… (#888)

* working on cleaning up warnings when -Wconversion is enabled, there's... a lot

* working out some more warnings

* more warning squashing...

* squashing almost all of them now!

* the last of them... i think

* some minor tweaks

* a little bit more...

* the last of it?

* forgot to account for debug builds!

* this one only occurs when graphing is enabled

* some more small improvements

* formatting

* removing some pointless code

* formatting
better auto usage

Author: eteran

cmake/Modules/AddWarnings.cmake

@@ -14,7 +14,7 @@ function(TARGET_ADD_WARNINGS TARGET)
 			-Wunused
 			-Woverloaded-virtual
 			-pedantic
-			#-Wconversion
+			-Wconversion
 			#-Wsign-conversion
 			#-Wnull-dereference
 			-Wdouble-promotion

edb.appdata.xml

@@ -6,25 +6,25 @@
     <project_license>GPL-2.0</project_license>
     <name>edb</name>
     <summary>Reverse engineer's debugger</summary>
-<!--
+    <!--
     <developer id="io.github.eteran">
    	 <name>edb-debugger</name>
     </developer>
--->
+    -->
     <developer_name>edb-debugger</developer_name>
     <description>
-		<p>edb is a cross platform x86/x86-64 debugger. It was inspired by OllyDbg, 
-		   but aims to function on x86 and x86-64 as well as multiple OS's.
-		</p>
-		<p>Linux is the only officially supported platform at the moment, but FreeBSD, 
-                   OpenBSD, OSX and Windows ports are underway with varying degrees of functionality.
- 		</p>
+        <p>edb is a cross platform x86/x86-64 debugger. It was inspired by OllyDbg,
+            but aims to function on x86 and x86-64 as well as multiple OS's.
+        </p>
+        <p>Linux is the only officially supported platform at the moment, but FreeBSD,
+            OpenBSD, OSX and Windows ports are underway with varying degrees of functionality.
+        </p>
     </description>
     <screenshots>
         <screenshot type="default" width="1121" height="839">
-		<image>http://codef00.com/img/debugger.png</image>
-		<caption>Main Window, with disassembly, data, stack and registers</caption>
-	</screenshot>
+            <image>http://codef00.com/img/debugger.png</image>
+            <caption>Main Window, with disassembly, data, stack and registers</caption>
+        </screenshot>
     </screenshots>
     <update_contact>evan.teran_at_gmail.com</update_contact>
     <url type="homepage">https://github.com/eteran/edb-debugger</url>
@@ -36,7 +36,7 @@
         <content_attribute id="social-info">mild</content_attribute>
     </content_rating>
     <releases>
-	<release version="1.5.0" date="2024-03-22"></release>
+        <release version="1.5.0" date="2024-03-22"></release>
         <release version="1.4.0" date="2023-06-30"></release>
     </releases>
 </component>

include/BasicBlock.h

@@ -59,7 +59,7 @@ class EDB_EXPORT BasicBlock {
 	[[nodiscard]] bool empty() const;
 
 public:
-	void swap(BasicBlock &other);
+	void swap(BasicBlock &other) noexcept;
 
 public:
 	[[nodiscard]] QString toString() const;

include/BinaryString.h

@@ -27,7 +27,7 @@ class EDB_EXPORT BinaryString : public QWidget {
 	};
 
 public:
-	BinaryString(QWidget *parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags());
+	explicit BinaryString(QWidget *parent = nullptr, Qt::WindowFlags f = Qt::WindowFlags());
 	~BinaryString() override;
 
 private Q_SLOTS:

include/ByteShiftArray.h

@@ -22,7 +22,7 @@ class EDB_EXPORT ByteShiftArray {
 	ByteShiftArray &shl();
 	ByteShiftArray &shr();
 	void clear();
-	void swap(ByteShiftArray &other);
+	void swap(ByteShiftArray &other) noexcept;
 
 public:
 	ByteShiftArray &operator<<(uint8_t x);

include/Configuration.h

@@ -16,7 +16,7 @@
 class EDB_EXPORT Configuration : public QObject {
 	Q_OBJECT
 public:
-	Configuration(QObject *parent = nullptr);
+	explicit Configuration(QObject *parent = nullptr);
 	~Configuration() override;
 
 public:

include/Function.h

@@ -70,7 +70,7 @@ class EDB_EXPORT Function {
 	[[nodiscard]] int referenceCount() const;
 
 public:
-	void swap(Function &other);
+	void swap(Function &other) noexcept;
 
 private:
 	int referenceCount_ = 0;

include/State.h

@@ -38,7 +38,7 @@ class EDB_EXPORT State {
 	~State();
 
 public:
-	void swap(State &other);
+	void swap(State &other) noexcept;
 
 public:
 	[[nodiscard]] bool empty() const;

include/Value.h

@@ -28,6 +28,13 @@ namespace v1 {
 EDB_EXPORT bool debuggeeIs32Bit();
 }
 
+// TODO(eteran): honestly, this whole file is filled with conversions, so the warnings about conversions are not really helpful.
+// Of course, we should audit the code to make sure that all conversions are intentional and safe. For now, suppress the warnings
+// about conversions in this file as it's just too loud when they are enabled.
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wconversion"
+#pragma GCC diagnostic ignored "-Wsign-conversion"
+
 namespace detail {
 
 template <class Integer>
@@ -225,7 +232,7 @@ class value_type {
 	}
 
 public:
-	void swap(value_type &other) {
+	void swap(value_type &other) noexcept {
 		using std::swap;
 		swap(value_, other.value_);
 	}
@@ -854,6 +861,8 @@ static_assert(sizeof(value_type80) * 8 == 80, "value_type80 size is broken!");
 
 }
 
+#pragma GCC diagnostic pop
+
 // GPR on x86
 using value8  = detail::value_type<uint8_t>;
 using value16 = detail::value_type<uint16_t>;

include/edb.h

@@ -62,7 +62,7 @@ namespace v1 {
 EDB_EXPORT extern IDebugger *debugger_core;
 EDB_EXPORT extern QWidget *debugger_ui;
 
-// the symbol mananger
+// the symbol manager
 EDB_EXPORT ISymbolManager &symbol_manager();
 
 // the memory region manager
@@ -74,7 +74,7 @@ EDB_EXPORT ArchProcessor &arch_processor();
 // widgets
 EDB_EXPORT QAbstractScrollArea *disassembly_widget();
 
-// breakpoint managment
+// breakpoint management
 EDB_EXPORT std::shared_ptr<IBreakpoint> find_breakpoint(address_t address);
 EDB_EXPORT std::shared_ptr<IBreakpoint> find_triggered_breakpoint(address_t address);
 EDB_EXPORT QString get_breakpoint_condition(address_t address);
@@ -175,7 +175,7 @@ EDB_EXPORT void update_ui();
 
 // these are here and not members of state because
 // they may require using the debugger core plugin and
-// we don't want to force a dependancy between the two
+// we don't want to force a dependency between the two
 EDB_EXPORT void pop_value(State *state);
 EDB_EXPORT void push_value(State *state, reg_t value);