fix: resolve CI failures and remaining SonarCloud issues

- Reverted Menu.tsx <button> back to <a> to fix E2E test selector
- Changed HeaderLinks from div[role=button] to actual <button> elements
- Fixed duplicate setRouteKey declaration in useSingleLineData
- Used ?? for ternary in ArrivalByTimeChart tooltip
- Reverted Recharts Tooltip useCallback (type incompatibility)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: eran132

src/hooks/useSingleLineData.ts

@@ -21,7 +21,7 @@ export const useSingleLineData = (
 ) => {
   const { search, setSearch } = useContext(SearchContext)
   const [routes, setRoutes] = useState<BusRoute[] | undefined>(search.routes)
-  const [routeKey, setRouteKeyState] = useState<string | undefined>(search.routeKey)
+  const [routeKey, _setRouteKey] = useState<string | undefined>(search.routeKey)
   const [filteredPositions, setFilteredPositions] = useState<Point[]>([])
   const [plannedRouteStops, setPlannedRouteStops] = useState<BusStop[]>([])
   const [options, setOptions] = useState<{ value: string; label: string }[]>([])
@@ -37,7 +37,7 @@ export const useSingleLineData = (
 
   const setRouteKey = useCallback(
     (routeKey?: string) => {
-      setRouteKeyState(routeKey)
+      _setRouteKey(routeKey)
       setSearch((prev) => ({ ...prev, routeKey }))
     },
     [setSearch],

src/layout/header/HeaderLinks/HeaderLinks.tsx

@@ -35,18 +35,14 @@ const ExternalLink = ({ label, path, icon }: LinkType) => {
     window.open(path, '_blank')
   }
   return (
-    <div
+    <button
+      type="button"
       className="header-link"
       aria-label={t(label)}
       title={t(label)}
-      role="button"
-      tabIndex={0}
-      onClick={handleClick}
-      onKeyDown={(e) => {
-        if (e.key === 'Enter' || e.key === ' ') handleClick()
-      }}>
+      onClick={handleClick}>
       {icon}
-    </div>
+    </button>
   )
 }
 
@@ -57,18 +53,14 @@ const InternalLink = ({ label, path, icon }: LinkType) => {
     navigate(path)
   }
   return (
-    <div
+    <button
+      type="button"
       aria-label={t(label)}
       title={t(label)}
       className="header-link"
-      role="button"
-      tabIndex={0}
-      onClick={handleClick}
-      onKeyDown={(e) => {
-        if (e.key === 'Enter' || e.key === ' ') handleClick()
-      }}>
+      onClick={handleClick}>
       {icon}
-    </div>
+    </button>
   )
 }
 

src/layout/sidebar/menu/Menu.tsx

@@ -66,9 +66,9 @@ const MainMenu = ({ collapsed = false }: MainMenuProps) => {
     acc[itm.path] =
       itm.label === 'donate_title'
         ? getItem(
-            <button type="button" onClick={handleDonateClick}>
+            <a href="#" onClick={handleDonateClick}>
               {t(itm.label)}
-            </button>,
+            </a>,
             itm.path,
             itm.icon,
           )

src/pages/dashboard/ArrivalByTimeChart/ArrivalByTimeChart.tsx

@@ -114,11 +114,9 @@ const ArrivalByTimeTooltipContent = ({
       <InfoTable>
         <InfoItem
           label={t('sample_time')}
-          value={dayjs(
-            payload[0].payload.gtfsRouteHour
-              ? payload[0].payload.gtfsRouteHour
-              : payload[0].payload.gtfsRouteDate,
-          ).format(payload[0].payload.gtfsRouteHour ? 'HH:mm-DD/MM/YY' : 'DD/MM/YY')}
+          value={dayjs(payload[0].payload.gtfsRouteHour ?? payload[0].payload.gtfsRouteDate).format(
+            payload[0].payload.gtfsRouteHour ? 'HH:mm-DD/MM/YY' : 'DD/MM/YY',
+          )}
         />
         <InfoItem label={t('rides_actual')} value={payload[0].payload.current} />
         <InfoItem label={t('rides_planned')} value={payload[0].payload.max} />
@@ -137,7 +135,6 @@ export default function ArrivalByTimeChart({
   const { t } = useTranslation()
   const filteredData = useMemo(() => filterDataByOperator(data, operatorId), [data, operatorId])
   const groupedData = useMemo(() => groupDataByHourOrDay(filteredData), [filteredData])
-
   return (
     <div className="chart">
       {Object.values(groupedData).map((operatorData) => (