Skip to content

Commit e7a9d08

Browse files
authored
docs(ci): document the docker/login-action tag-resolution quirk (#394)
Dependabot has at least once bumped docker/login-action to an untagged main-branch commit (PR #346) with a stale/misleading trailing version comment, while sibling actions bumped in other PRs resolved correctly (#351, #354) -- specific to this one action, not general dependabot behavior. Neither of the issue's two suggested mechanical fixes apply cleanly: extending the pin-check CI job lives in a separate central reusable-workflow repo, and adding an ignore rule would trade off automatic updates against this recurrence risk -- both are maintainer decisions. Document the quirk so a future docker/login-action bump gets its tag double-checked before merging. Closes #364
1 parent ff232e9 commit e7a9d08

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

.github/dependabot.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@ updates:
4343
cooldown:
4444
default-days: 7
4545
directory: /
46+
# Known quirk (nsip#364): dependabot has bumped docker/login-action to an
47+
# untagged main-branch commit at least once (PR #346), leaving a stale/
48+
# misleading trailing `# vX.Y.Z` comment on the uses: pin rather than
49+
# landing on a real release tag. Sibling actions bumped in other PRs
50+
# (actions/checkout, taiki-e/install-action -- see #351, #354) resolved
51+
# correctly, so this is specific to docker/login-action, not a general
52+
# dependabot behavior. When reviewing a docker/login-action bump PR,
53+
# verify the target SHA matches a real tag
54+
# (`gh api repos/docker/login-action/tags`) before merging -- do not
55+
# trust the trailing version comment alone.
4656
exclude-paths:
4757
# gh-aw-generated workflows (gh aw compile). Every action embedded in these
4858
# files -- not just github/gh-aw-actions/** -- is version-locked to the

0 commit comments

Comments
 (0)