Paginate images. (#342)

Author: lewisgoddard

data/development-images.json

@@ -16,17 +16,23 @@ const s3 = new S3({
 })
 
 async function downloadImages () {
-  const manifest = await new Promise((resolve, reject) => {
-    s3.listObjects({ Bucket: 'elementary-iso' }, (err, data) => {
-      if (err != null) {
-        return reject(err)
-      } else {
-        return resolve(data)
-      }
-    })
-  })
-
-  return manifest.Contents
+  const allContents = []
+  let marker = null
+
+  do {
+    const params = { Bucket: 'elementary-iso' }
+    if (marker) {
+      params.Marker = marker
+    }
+
+    const data = await s3.listObjects(params)
+    allContents.push(...data.Contents)
+    marker = data.IsTruncated
+      ? data.Contents[data.Contents.length - 1].Key
+      : null
+  } while (marker)
+
+  return allContents
     .filter(({ Key }) => Key.endsWith('.iso') || Key.endsWith('.img.xz'))
     .map(d => ({
       path: d.Key,

server/images.js

@@ -6,7 +6,9 @@ export const getters = {
   imagesFor: (state, getters) => (channel = 'daily') => {
     return getters.images
       .filter(({ path }) => path.startsWith(`${channel}/`))
-      .filter(({ path }) => path.includes('7.0') || path.includes('7.1') || path.includes('8.0') || path.includes('8.1'))
+      // This filter allows us to build dailies for future releases internally before allowing them to be public.
+      // It only modifies the images shown in the UI, not the actual images that are available for download.
+      .filter(({ path }) => path.includes('8.0') || path.includes('8.1'))
   },
 
   images (state) {