[bugfix] SequenceType: restrict function-arity check to function() typed tests

Commit 0d96ad8 added function-arity + return-type checking in
SequenceType.checkType under Type.subTypeOf(primaryType, Type.FUNCTION).
Because MAP_ITEM and ARRAY_ITEM are declared subtypes of FUNCTION, the
arity check also applied to typed map(K,V) and array(T) tests -- but
the underlying map accessor signature carries one argument (the key),
while map(K,V) carries two type parameters in the test syntax. The
arity comparison therefore always returned false, so any
"$x instance of map(xs:string, item()?)" check failed and the value
flowed down the else branch unchanged. Concretely this caused the
xquery3 recursion-function-calls-002 test to fail with FOTY0013
("A function item other than an array cannot be atomized") when the
recursive local:join was bypassed and a raw map landed inside
string-join.

Narrow the function-type check to primaryType == Type.FUNCTION so the
plain function() typed-test still gets validated (including on map and
array values that satisfy it via FUNCTION subtyping), while map(K,V)
and array(T) tests revert to their pre-0d96ad8a19 behaviour pending
proper typed-test support.

Also: update the id.xqm securitymanager fixture's stored module from
'xquery version "3.0"' to "3.1" so that the stricter loaded-module
version check added in 7966280 no longer rejects it.

Addresses Juri's second review comment on PR #6344 (recursion-function-
calls-002 failure).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: joewiz

exist-core/src/main/java/org/exist/xquery/value/SequenceType.java

@@ -177,8 +177,14 @@ public boolean checkType(final Item item) {
             return false;
         }
 
-        // For function types, check parameter and return type compatibility
-        if (Type.subTypeOf(primaryType, Type.FUNCTION) && item instanceof FunctionReference
+        // For typed function() tests, check parameter and return type compatibility.
+        // MAP_ITEM and ARRAY_ITEM are subtypes of FUNCTION but use distinct typed-test
+        // syntax (map(K,V), array(T)) whose parameter counts do not match the
+        // underlying function signature's argument count (a map's accessor signature
+        // takes 1 arg, the key; map(K,V) carries 2 type parameters). Restrict the
+        // function-arity/return check to plain function() tests so map and array
+        // values continue to satisfy their typed tests.
+        if (primaryType == Type.FUNCTION && item instanceof FunctionReference
                 && !checkFunctionType((FunctionReference) item)) {
             return false;
         }

exist-core/src/test/xquery/securitymanager/id.xqm

@@ -35,7 +35,7 @@ declare
     %test:setUp
 function id:setup() {
     xmldb:create-collection("/db", $id:TEST_COLLECTION_NAME),
-    xmldb:store($id:TEST_COLLECTION_PATH, $id:TEST_MODULE_NAME, 'xquery version "3.0";
+    xmldb:store($id:TEST_COLLECTION_PATH, $id:TEST_MODULE_NAME, 'xquery version "3.1";
 
 module namespace mod1 = "http://module1";