Commit 469d60c
committed
[refactor] Address 4 low-risk Codacy findings on this PR
Quick wins picked from the Codacy report — small, mechanical cleanups
that do not touch any of the pre-existing NPath complexity territory
that @line-o flagged as a conflict-with-other-PRs risk.
- FunUnparsedText.java: replace fully-qualified StandardCharsets.UTF_8
with the already-static-imported UTF_8 (UnnecessaryFullyQualifiedName)
- FunMatches.java: collapse a nested if into a single condition
(CollapsibleIfStatements)
- XQueryContext.ModuleVertex.equals: combine the two-step namespace +
location comparison into a single && return (SimplifyBooleanReturns)
- RegexUtil.java: remove unused convertUnicodeBlockNames(String) private
method (UnusedPrivateMethod) -- left over from an early Java-regex
implementation attempt before the validation path moved to Saxon
The remaining 10 NPath complexity warnings and the AvoidReassigningParameters
warnings are left untouched per @line-o's note about pre-existing complexity
raising conflict risk with other PRs in the pipeline.
Verified: build clean, XQuery3Tests 1026/1026 pass.1 parent 6b1c890 commit 469d60c
4 files changed
Lines changed: 6 additions & 22 deletions
File tree
- exist-core/src/main/java/org/exist/xquery
- functions/fn
- regex
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3874 | 3874 | | |
3875 | 3875 | | |
3876 | 3876 | | |
3877 | | - | |
3878 | | - | |
3879 | | - | |
3880 | | - | |
| 3877 | + | |
3881 | 3878 | | |
3882 | 3879 | | |
3883 | 3880 | | |
| |||
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
450 | 447 | | |
451 | 448 | | |
452 | 449 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
320 | 320 | | |
321 | 321 | | |
322 | 322 | | |
323 | | - | |
| 323 | + | |
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
| |||
Lines changed: 0 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | 163 | | |
174 | 164 | | |
175 | 165 | | |
| |||
0 commit comments