[StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) (#10021)

* Add missing accessibility modifiers in System.Xaml

* Post merge changes

* IDE0040 Part 1 with config removal

* IDE0040 Final part cleanup

* Remove SA1400 as well

* Fix up release build

* Fix post-merge issue

* Fix IDE0040 in csp wrapper

* Modify MilCodeGen to include accessibility modifiers

Author: h3xds1nz

src/Microsoft.DotNet.Wpf/src/.editorconfig

@@ -173,9 +173,6 @@ dotnet_diagnostic.IDE0034.severity = suggestion
 # IDE0036: Order modifiers
 dotnet_diagnostic.IDE0036.severity = suggestion
 
-# IDE0040: Add accessibility modifiers
-dotnet_diagnostic.IDE0040.severity = suggestion
-
 # IDE0041: Use 'is null' check
 dotnet_diagnostic.IDE0041.severity = suggestion
 
@@ -250,10 +247,6 @@ dotnet_diagnostic.IDE1006.severity = suggestion
 
 # SA1000: Spacing around keywords
 dotnet_diagnostic.SA1000.severity = suggestion
-
-# SA1400: Member should declare an access modifier
-dotnet_diagnostic.SA1400.severity = suggestion
-
 # SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
 dotnet_diagnostic.SYSLIB1045.severity = suggestion
 

src/Microsoft.DotNet.Wpf/src/Common/Graphics/exports.cs

@@ -323,13 +323,13 @@ internal sealed partial class Channel
             /// <summary>
             /// Primary channel.
             /// </summary>
-            IntPtr _hChannel;
+            private IntPtr _hChannel;
 
             private Channel _referenceChannel;
             private bool _isSynchronous;
             private bool _isOutOfBandChannel;
 
-            IntPtr _pConnection;
+            private IntPtr _pConnection;
 
             /// <summary>
             /// Creates a channel and associates it with channel group (partition).

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_render.cs

@@ -584,7 +584,7 @@ internal enum ChildType
         eChildLast = 0x2
     };
 
-    enum MILResourceType
+    internal enum MILResourceType
     {
         eMILResourceVideo = 0,
         eMILCOB = 1,
@@ -594,7 +594,7 @@ enum MILResourceType
         eMILResourceLast = 5
     };
 
-    enum MILAVInstructionType
+    internal enum MILAVInstructionType
     {
         eAVPlay = 0,
         eAVStop,
@@ -658,61 +658,61 @@ internal enum WICComponentType
     [StructLayout(LayoutKind.Sequential)]
     internal struct WICBitmapPattern
     {
-        Int64 Offset;
-        UInt32 Length;
-        IntPtr Pattern;
-        IntPtr Mask;
+        private Int64 Offset;
+        private UInt32 Length;
+        private IntPtr Pattern;
+        private IntPtr Mask;
     }
 
     [StructLayout(LayoutKind.Sequential)]
     internal struct MILBitmapItem
     {
-        uint          Size;
-        IntPtr        Desc;
-        uint          DescSize;
-        IntPtr        Data;
-        uint          DataSize;
-        uint          Cookie;
+        private uint          Size;
+        private IntPtr        Desc;
+        private uint          DescSize;
+        private IntPtr        Data;
+        private uint          DataSize;
+        private uint          Cookie;
     };
 
     [StructLayout(LayoutKind.Sequential)]
     internal struct BitmapTransformCaps
     {
         // Size of this structure.
 
-        int nSize;
+        private int nSize;
 
         // minimum number of inputs required.
 
-        int cMinInputs;
+        private int cMinInputs;
 
         // maximum number of inputs that will be processed.
 
-        int cMaxInputs;
+        private int cMaxInputs;
 
         // Set to false requires all the inputs and the
         // output to have the same pixel format determined
         // by calling IsPixelFormatSupported() for any
         // index. Set to true allows different input/output
         // pixel formats.
 
-        [MarshalAs(UnmanagedType.Bool)] bool fSupportMultiFormat;
+        [MarshalAs(UnmanagedType.Bool)] private bool fSupportMultiFormat;
 
         // Supports auxilliary data out.
 
-        [MarshalAs(UnmanagedType.Bool)] bool fAuxiliaryData;
+        [MarshalAs(UnmanagedType.Bool)] private bool fAuxiliaryData;
 
         // TRUE if the effect supports multiple output
 
-        [MarshalAs(UnmanagedType.Bool)] bool fSupportMultiOutput;
+        [MarshalAs(UnmanagedType.Bool)] private bool fSupportMultiOutput;
 
         // TRUE if the effect can provide output band by band
 
-        [MarshalAs(UnmanagedType.Bool)] bool fSupportBanding;
+        [MarshalAs(UnmanagedType.Bool)] private bool fSupportBanding;
 
         // TRUE if the effect supports multi-resolution
 
-        [MarshalAs(UnmanagedType.Bool)] bool fSupportMultiResolution;
+        [MarshalAs(UnmanagedType.Bool)] private bool fSupportMultiResolution;
 };
 
     [StructLayout(LayoutKind.Sequential)]

src/Microsoft.DotNet.Wpf/src/Extensions/PresentationFramework-SystemCore/DynamicAccessorImpl.cs

@@ -44,8 +44,8 @@ public override void SetValue(object component, object value)
             _setter.Target(_setter, component, value);
         }
 
-        CallSite<Func<CallSite, object, object>> _getter;
-        CallSite<Action<CallSite, object, object>> _setter;
+        private CallSite<Func<CallSite, object, object>> _getter;
+        private CallSite<Action<CallSite, object, object>> _setter;
     }
 
     #endregion DynamicPropertyAccessorImpl
@@ -152,11 +152,11 @@ public static DynamicIndexerAccessor GetIndexerAccessor(int rank)
             return _accessors[rank-1];
         }
 
-        CallSite            _getterCallSite, _setterCallSite;
-        MulticastDelegate   _getterDelegate, _setterDelegate;
+        private CallSite _getterCallSite, _setterCallSite;
+        private MulticastDelegate _getterDelegate, _setterDelegate;
 
-        static DynamicIndexerAccessor[] _accessors = new DynamicIndexerAccessor[1];
-        static readonly object _lock = new object();
+        private static DynamicIndexerAccessor[] _accessors = new DynamicIndexerAccessor[1];
+        private static readonly object _lock = new object();
     }
 
     #endregion DynamicIndexerAccessor

src/Microsoft.DotNet.Wpf/src/Extensions/PresentationFramework-SystemData/SystemDataExtension.cs

@@ -220,11 +220,11 @@ public DataTableToDataViewLink(DataTable dataTable, object target)
                 dataTable.Initialized += OnInitialized;
             }
 
-            void OnInitialized(object sender, EventArgs e)
+            private void OnInitialized(object sender, EventArgs e)
             {
             }
 
-            object _target;
+            private object _target;
         }
 
         private class DataRowViewToRelatedViewLink
@@ -235,15 +235,15 @@ public DataRowViewToRelatedViewLink(DataRowView dataRowView, object target)
                 dataRowView.PropertyChanged += OnPropertyChanged;
             }
 
-            void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
+            private void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
             {
             }
 
-            object _target;
+            private object _target;
         }
 
-        static Type s_DataTablePropertyDescriptorType;
-        static Type s_DataRelationPropertyDescriptorType;
+        private static Type s_DataTablePropertyDescriptorType;
+        private static Type s_DataRelationPropertyDescriptorType;
     }
 }
 

src/Microsoft.DotNet.Wpf/src/Extensions/PresentationFramework-SystemXml/XmlNodeComparer.cs

@@ -60,7 +60,7 @@ int IComparer.Compare(object o1, object o2)
 
         private SortDescriptionCollection  _sortParameters;
         private XmlNamespaceManager  _namespaceManager;
-        CultureInfo _culture;
+        private CultureInfo _culture;
     }
 }
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/MarkupCompiler.cs

@@ -709,11 +709,11 @@ private SourceFileInfo OnSourceFileResolve(FileUnit file)
             return sourceFileInfo;
         }
 
-#endregion CompileUnit
+        #endregion CompileUnit
 
-#region ErrorHandling
+        #region ErrorHandling
 
-        static void ThrowCompilerException(string id)
+        private static void ThrowCompilerException(string id)
         {
             string message = SR.GetResourceString(id);
             ThrowCompilerExceptionImpl(message);
@@ -737,13 +737,13 @@ internal static void ThrowCompilerException(string id, string value1, string val
             ThrowCompilerExceptionImpl(message);
         }
 
-        static void ThrowCompilerException(string id, string value1, string value2, string value3, string value4)
+        private static void ThrowCompilerException(string id, string value1, string value2, string value3, string value4)
         {
             string message = SR.Format(SR.GetResourceString(id), value1, value2, value3, value4);
             ThrowCompilerExceptionImpl(message);
         }
 
-        static void ThrowCompilerExceptionImpl(string message)
+        private static void ThrowCompilerExceptionImpl(string message)
         {
             Exception compilerException = new Exception(message);
             throw compilerException;

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/ParserExtension.cs

@@ -914,7 +914,7 @@ internal override bool CanResolveLocalAssemblies()
             return _pass2;
         }
 
-        bool ProcessedRootElement
+        private bool ProcessedRootElement
         {
             get { return _processedRootElement; }
             set { _processedRootElement = value; }

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/VersionHelper.cs

@@ -14,7 +14,7 @@ namespace MS.Internal
 {
     internal static class VersionHelper
     {
-        static readonly Version NullVersion = new Version(0, 0, 0, 0);
+        private static readonly Version NullVersion = new Version(0, 0, 0, 0);
 
         /// <summary>
         /// Parses a version string of the form "major [ '.' minor [ '.' build [ '.' revision ] ] ]".

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/GenerateTemporaryTargetAssembly.cs

@@ -866,7 +866,7 @@ private static void ReplaceImplicitImports(XmlDocument xmlProjectDoc)
         // Creates an XmlNode that contains an Import Project element
         //
         //  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
-        static XmlNode CreateImportProjectSdkNode(XmlDocument xmlProjectDoc, string projectAttributeValue, SdkReference sdkReference)
+        private static XmlNode CreateImportProjectSdkNode(XmlDocument xmlProjectDoc, string projectAttributeValue, SdkReference sdkReference)
         {
             XmlNode nodeImport = xmlProjectDoc.CreateElement("Import", xmlProjectDoc.DocumentElement.NamespaceURI);
             XmlAttribute projectAttribute = xmlProjectDoc.CreateAttribute("Project");