Commit 9b4fd4e
authored
fix(scripts): use dfx for wallet-routed staging upgrades in release SOP (#3815)
## Summary
The recent dfx -> icp-cli migration mapped \`--wallet\` to \`--proxy\`
per the [migration
guide](https://cli.internetcomputer.org/0.2/migration/from-dfx.md), but
those flags aren't equivalent:
- icp-cli's \`--proxy\` calls a \`proxy\` method on a custom proxy
canister.
- A dfx wallet canister exposes \`wallet_call\` / \`wallet_call128\`.
So pointing \`icp canister install --proxy\` at the existing II wallet
(\`cvthj-wyaaa-aaaad-aaaaq-cai\`) traps with _\"Canister has no update
method 'proxy'\"_, which breaks the staging deploy step of the release
SOP — running \`scripts/make-upgrade-proposal\` fails before any
proposal is created.
icp-cli has no equivalent for the dfx wallet's \`wallet_call\`, so this
PR falls back to dfx for the two staging deploy functions only. The rest
of the script stays on icp-cli.1 parent 7fb3bea commit 9b4fd4e
1 file changed
Lines changed: 14 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
435 | 435 | | |
436 | 436 | | |
437 | 437 | | |
438 | | - | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
439 | 444 | | |
440 | | - | |
441 | | - | |
442 | 445 | | |
443 | 446 | | |
444 | | - | |
445 | | - | |
| 447 | + | |
| 448 | + | |
446 | 449 | | |
447 | 450 | | |
448 | 451 | | |
449 | 452 | | |
450 | | - | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
451 | 457 | | |
452 | | - | |
453 | | - | |
454 | 458 | | |
455 | 459 | | |
456 | | - | |
457 | | - | |
| 460 | + | |
| 461 | + | |
458 | 462 | | |
459 | 463 | | |
460 | 464 | | |
| |||
0 commit comments