Skip to content

Commit 9b4fd4e

Browse files
authored
fix(scripts): use dfx for wallet-routed staging upgrades in release SOP (#3815)
## Summary The recent dfx -> icp-cli migration mapped \`--wallet\` to \`--proxy\` per the [migration guide](https://cli.internetcomputer.org/0.2/migration/from-dfx.md), but those flags aren't equivalent: - icp-cli's \`--proxy\` calls a \`proxy\` method on a custom proxy canister. - A dfx wallet canister exposes \`wallet_call\` / \`wallet_call128\`. So pointing \`icp canister install --proxy\` at the existing II wallet (\`cvthj-wyaaa-aaaad-aaaaq-cai\`) traps with _\"Canister has no update method 'proxy'\"_, which breaks the staging deploy step of the release SOP — running \`scripts/make-upgrade-proposal\` fails before any proposal is created. icp-cli has no equivalent for the dfx wallet's \`wallet_call\`, so this PR falls back to dfx for the two staging deploy functions only. The rest of the script stays on icp-cli.
1 parent 7fb3bea commit 9b4fd4e

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

scripts/make-upgrade-proposal

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -435,26 +435,30 @@ prepare_staging_frontend_argument() {
435435

436436
deploy_staging_backend() {
437437
echo "Deploying II backend release candidate to staging"
438-
icp canister \
438+
# icp-cli's --proxy expects a custom proxy canister exposing a `proxy`
439+
# method, which is NOT what a dfx wallet canister implements. Use dfx
440+
# here so wallet_call routing keeps working against the existing wallet.
441+
dfx canister \
442+
--network ic \
443+
--wallet cvthj-wyaaa-aaaad-aaaaq-cai \
439444
install "$STAGING_BACKEND_CANISTER_ID" \
440-
-e ic \
441-
--proxy cvthj-wyaaa-aaaad-aaaaq-cai \
442445
--mode upgrade \
443446
--wasm ./internet_identity.wasm.gz \
444-
--args-format bin \
445-
--args "$(cat ./staging_icp_arg.bin)"
447+
--argument-type raw \
448+
--argument "$(cat ./staging_icp_arg.bin)"
446449
}
447450

448451
deploy_staging_frontend() {
449452
echo "Deploying II frontend release candidate to staging"
450-
icp canister \
453+
# See deploy_staging_backend: dfx is used here for wallet-routed upgrades.
454+
dfx canister \
455+
--network ic \
456+
--wallet cvthj-wyaaa-aaaad-aaaaq-cai \
451457
install "$STAGING_FRONTEND_CANISTER_ID" \
452-
-e ic \
453-
--proxy cvthj-wyaaa-aaaad-aaaaq-cai \
454458
--mode upgrade \
455459
--wasm ./internet_identity_frontend.wasm.gz \
456-
--args-format bin \
457-
--args "$(cat ./staging_icp_frontend_arg.bin)"
460+
--argument-type raw \
461+
--argument "$(cat ./staging_icp_frontend_arg.bin)"
458462
}
459463

460464
test_release_candidate() {

0 commit comments

Comments
 (0)