Skip to content

Commit f85d85d

Browse files
fix: validate action-commit-push against published test images (#131)
Switch action-commit-push reusable CI flows from ref-based E2E to published image validation. Use -test images for PR workflows, -rc images for release-prepare, and release tags for release-create so Docker-action validation matches the shipped artifact. Co-authored-by: ChristophShyper <45788587+ChristophShyper@users.noreply.github.com>
1 parent 1d26437 commit f85d85d

3 files changed

Lines changed: 14 additions & 19 deletions

File tree

.github/workflows/reusable-auto-pull-request-create.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -204,27 +204,26 @@ jobs:
204204

205205
e2e-action-commit-push:
206206
if: inputs.profile == 'actions' && github.event.repository.name == 'action-commit-push'
207-
needs: [pull-request]
207+
needs: [docker]
208208
permissions:
209209
contents: write
210210
uses: devops-infra/triglav/.github/workflows/e2e-action-commit-push.yml@master
211211
with:
212-
mode: ref
213-
image_tag: ''
214-
action_ref: ${{ github.sha }}
212+
mode: image
213+
image_tag: ${{ needs.docker.outputs.image_tag }}
215214
secrets: inherit
216215

217216
e2e-action-pull-request:
218217
if: inputs.profile == 'actions' && github.event.repository.name == 'action-pull-request'
219-
needs: [pull-request]
218+
needs: [docker]
220219
permissions:
221220
contents: write
222221
pull-requests: write
223222
issues: write
224223
uses: devops-infra/triglav/.github/workflows/e2e-action-pull-request.yml@master
225224
with:
226-
mode: ref
227-
image_tag: ''
225+
mode: image
226+
image_tag: ${{ needs.docker.outputs.image_tag }}
228227
secrets: inherit
229228

230229
e2e-action-container-structure-test:

.github/workflows/reusable-auto-release-create.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,8 @@ jobs:
305305
contents: write
306306
uses: devops-infra/triglav/.github/workflows/e2e-action-commit-push.yml@master
307307
with:
308-
mode: ref
309-
image_tag: ''
310-
action_ref: ${{ github.sha }}
308+
mode: image
309+
image_tag: ${{ needs.release.outputs.release_version }}
311310
secrets: inherit
312311

313312
publish-action-commit-push-release:
@@ -417,9 +416,8 @@ jobs:
417416
issues: write
418417
uses: devops-infra/triglav/.github/workflows/e2e-action-pull-request.yml@master
419418
with:
420-
mode: ref
421-
action_ref: ${{ github.sha }}
422-
image_tag: ''
419+
mode: image
420+
image_tag: ${{ needs.release.outputs.release_version }}
423421
secrets: inherit
424422

425423
publish-action-pull-request-release:

.github/workflows/reusable-manual-release-branch-prepare.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -291,9 +291,8 @@ jobs:
291291
contents: write
292292
uses: devops-infra/triglav/.github/workflows/e2e-action-commit-push.yml@master
293293
with:
294-
mode: ref
295-
image_tag: ''
296-
action_ref: release/${{ needs.prepare.outputs.version }}
294+
mode: image
295+
image_tag: ${{ needs.prepare.outputs.version }}-rc
297296
secrets: inherit
298297

299298
e2e-action-pull-request:
@@ -305,9 +304,8 @@ jobs:
305304
issues: write
306305
uses: devops-infra/triglav/.github/workflows/e2e-action-pull-request.yml@master
307306
with:
308-
mode: ref
309-
action_ref: release/${{ needs.prepare.outputs.version }}
310-
image_tag: ''
307+
mode: image
308+
image_tag: ${{ needs.prepare.outputs.version }}-rc
311309
secrets: inherit
312310

313311
e2e-action-container-structure-test:

0 commit comments

Comments
 (0)