Skip to content

Commit f455cab

Browse files
authored
[Core] [Dataset] Fix build data set does not carry query SQL issue (#824)
2 parents 3df40a7 + ec8d4e8 commit f455cab

File tree

5 files changed

+24
-12
lines changed

5 files changed

+24
-12
lines changed

core/datacap-server/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@
4040
<groupId>org.springframework.boot</groupId>
4141
<artifactId>spring-boot-starter-log4j2</artifactId>
4242
<version>${springboot.version}</version>
43+
<exclusions>
44+
<exclusion>
45+
<artifactId>log4j-slf4j-impl</artifactId>
46+
<groupId>org.apache.logging.log4j</groupId>
47+
</exclusion>
48+
</exclusions>
4349
</dependency>
4450
<dependency>
4551
<groupId>redis.clients</groupId>

core/datacap-service/src/main/java/io/edurt/datacap/service/service/impl/DataSetServiceImpl.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ public CommonResponse<Object> adhoc(String code, Adhoc configure)
257257
targetConfigure.setUsername(Optional.ofNullable(initializerConfigure.getDataSetConfigure().getUsername()));
258258
targetConfigure.setPassword(Optional.ofNullable(initializerConfigure.getDataSetConfigure().getPassword()));
259259
targetConfigure.setDatabase(Optional.ofNullable(database));
260+
targetConfigure.setInjector(injector);
260261
plugin.connect(targetConfigure);
261262
Response response = plugin.execute(sql);
262263
response.setContent(sql);
@@ -337,6 +338,7 @@ private Configure getConfigure(String database)
337338
targetConfigure.setUsername(Optional.ofNullable(initializerConfigure.getDataSetConfigure().getUsername()));
338339
targetConfigure.setPassword(Optional.ofNullable(initializerConfigure.getDataSetConfigure().getPassword()));
339340
targetConfigure.setDatabase(Optional.ofNullable(database));
341+
targetConfigure.setInjector(injector);
340342
return targetConfigure;
341343
}
342344

@@ -551,7 +553,7 @@ private void syncData(DataSetEntity entity, ExecutorService service)
551553
try {
552554
SourceEntity source = entity.getSource();
553555
Optional<Plugin> pluginOptional = PluginUtils.getPluginByNameAndType(injector, source.getType(), source.getProtocol());
554-
if (!pluginOptional.isPresent()) {
556+
if (pluginOptional.isEmpty()) {
555557
throw new IllegalArgumentException(String.format("Plugin [ %s ] not found", initializerConfigure.getDataSetConfigure().getType()));
556558
}
557559

@@ -575,8 +577,10 @@ private void syncData(DataSetEntity entity, ExecutorService service)
575577
Properties inputProperties = ConfigureUtils.convertProperties(source, environment,
576578
IConfigurePipelineType.INPUT, entity.getExecutor(), entity.getQuery(), inputFieldBody);
577579
Set<String> inputOptions = ConfigureUtils.convertOptions(source, environment, entity.getExecutor(), IConfigurePipelineType.INPUT);
580+
Configure inputConfigure = source.toConfigure();
581+
inputConfigure.setInjector(injector);
578582
ExecutorConfigure input = new ExecutorConfigure(source.getType(), inputProperties, inputOptions, RunProtocol.valueOf(source.getProtocol()),
579-
inputPlugin, entity.getQuery(), database, entity.getTableName(), source.toConfigure(), originColumns);
583+
inputPlugin, entity.getQuery(), database, entity.getTableName(), inputConfigure, originColumns);
580584

581585
Plugin outputPlugin = PluginUtils.getPluginByNameAndType(injector, initializerConfigure.getDataSetConfigure().getType(), PluginType.JDBC.name()).orElseGet(null);
582586
SourceEntity outputSource = new SourceEntity();
@@ -776,7 +780,7 @@ private Set<CreatedModel> createdModeProcess(Set<DataSetColumnEntity> targetColu
776780
Optional<DataSetColumnEntity> filterColumn = targetColumns.stream()
777781
.filter(item -> item.getId().equals(sourceColumn.getId()))
778782
.findFirst();
779-
if (!filterColumn.isPresent()) {
783+
if (filterColumn.isEmpty()) {
780784
models.add(new CreatedModel(sourceColumn, CreatedMode.CREATE_COLUMN));
781785
}
782786
else {
@@ -816,7 +820,9 @@ private boolean checkTableExists(DataSetEntity entity)
816820
try {
817821
Plugin plugin = getOutputPlugin();
818822
SourceEntity source = getOutputSource();
819-
plugin.connect(source.toConfigure());
823+
Configure configure = source.toConfigure();
824+
configure.setInjector(injector);
825+
plugin.connect(configure);
820826
String sql = String.format("SHOW CREATE TABLE `%s`.`%s`", initializerConfigure.getDataSetConfigure().getDatabase(), entity.getTableName());
821827
log.info("Check table exists for dataset [ {} ] id [ {} ] sql \n {}", entity.getName(), entity.getId(), sql);
822828
Response response = plugin.execute(sql);

core/datacap-ui/src/views/pages/admin/dataset/DatasetInfo.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@
5959
<div>{{ $t('dataset.common.columnLength') }}</div>
6060
<div>{{ $t('common.action') }}</div>
6161
</div>
62-
<div class="grid gap-3 md:grid-cols-2 md:gap-3 lg:grid-cols-12 h-[480px] overflow-y-auto pt-2 pb-2">
62+
<div class="grid gap-3 md:grid-cols-2 md:gap-3 lg:grid-cols-12 overflow-y-auto pt-2 pb-2"
63+
:style="{ height: 'calc(100vh - 360px)' }">
6364
<template v-for="(item, index) in formState.columns" :key="index">
6465
<div>
6566
<Input v-model="item.name" type="text"/>
@@ -339,6 +340,7 @@ export default defineComponent({
339340
{
340341
const i18n = useI18n()
341342
const gridOptions = GridOptions.createDefaultOptions(i18n)
343+
342344
return {
343345
i18n,
344346
gridOptions
@@ -394,6 +396,7 @@ export default defineComponent({
394396
})
395397
const code = this.$route.params.code
396398
const sourceCode = this.$route.params.sourceCode
399+
397400
if (code) {
398401
this.loading = true
399402
this.code = code as string
@@ -414,6 +417,7 @@ export default defineComponent({
414417
.finally(() => this.loading = false)
415418
}
416419
else if (sourceCode) {
420+
this.value = localStorage.getItem('QueryContent') as string
417421
this.loading = true
418422
SourceService.getByCode(sourceCode as string)
419423
.then(response => {

core/datacap-ui/src/views/pages/admin/dataset/DatasetRebuild.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</AlertDialogTitle>
99
</AlertDialogHeader>
1010
<Alert>
11-
<AlertTitle>{{ $t('dataset.common.rebuildProgress') }}</AlertTitle>
11+
<AlertTitle>{{ $t('dataset.tip.rebuildProgress') }}</AlertTitle>
1212
</Alert>
1313
<AlertDialogFooter class="-mb-4 border-t pt-2">
1414
<Button :disabled="loading" @click="handlerRebuild">

core/datacap-ui/src/views/pages/admin/query/QueryHome.vue

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,12 +315,7 @@ export default defineComponent({
315315
// The configuration editor selects content events
316316
editor.selection.on('changeSelection', () => {
317317
const selection = editor.getSelection()
318-
if (selection.isEmpty()) {
319-
this.selectEditor.isSelection = false
320-
}
321-
else {
322-
this.selectEditor.isSelection = true
323-
}
318+
this.selectEditor.isSelection = !selection.isEmpty()
324319
})
325320
326321
langTools.addCompleter({
@@ -476,6 +471,7 @@ export default defineComponent({
476471
}
477472
this.responseConfigure.gridConfigure = tConfigure
478473
editorInstance.instance?.setValue(response.data.content)
474+
localStorage.setItem('QueryContent', content as string)
479475
}
480476
}
481477
else {

0 commit comments

Comments
 (0)