Skip to content

Commit 9a56e83

Browse files
committed
fix: correct rate limit check
1 parent 010cb8e commit 9a56e83

1 file changed

Lines changed: 20 additions & 16 deletions

File tree

index.ts

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,11 @@ export default class BulkAiFlowPlugin extends AdminForthPlugin {
109109
}
110110

111111
private async analyze_image(jobId: string, recordId: string, adminUser: any, headers: Record<string, string | string[] | undefined>, customPrompt? : string, filterFilledFields: boolean = true) {
112-
if (this.options.rateLimits && this.options.rateLimits.fillFieldsFromImages && await this.checkRateLimit("fillFieldsFromImages" ,this.options.rateLimits.fillFieldsFromImages, headers)) {
113-
jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
114-
return { error: "Rate limit exceeded" };
115-
}
112+
// TODO: need to do correct check of rate limit
113+
// if (this.options.rateLimits && this.options.rateLimits.fillFieldsFromImages && await this.checkRateLimit("fillFieldsFromImages" ,this.options.rateLimits.fillFieldsFromImages, headers)) {
114+
// jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
115+
// return { error: "Rate limit exceeded" };
116+
// }
116117
const selectedId = recordId;
117118
let isError = false;
118119
// Fetch the record using the provided ID
@@ -193,10 +194,11 @@ export default class BulkAiFlowPlugin extends AdminForthPlugin {
193194
}
194195

195196
private async analyzeNoImages(jobId: string, recordId: string, adminUser: any, headers: Record<string, string | string[] | undefined>, customPrompt? : string, filterFilledFields: boolean = true) {
196-
if (this.options.rateLimits && this.options.rateLimits.fillPlainFields && await this.checkRateLimit("fillPlainFields" ,this.options.rateLimits.fillPlainFields, headers)) {
197-
jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
198-
return { error: "Rate limit exceeded" };
199-
}
197+
// TODO: need to do correct check of rate limit
198+
// if (this.options.rateLimits && this.options.rateLimits.fillPlainFields && await this.checkRateLimit("fillPlainFields" ,this.options.rateLimits.fillPlainFields, headers)) {
199+
// jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
200+
// return { error: "Rate limit exceeded" };
201+
// }
200202
const selectedId = recordId;
201203
let isError = false;
202204
if (STUB_MODE) {
@@ -256,10 +258,11 @@ export default class BulkAiFlowPlugin extends AdminForthPlugin {
256258
}
257259

258260
private async initialImageGenerate(jobId: string, recordId: string, adminUser: any, headers: Record<string, string | string[] | undefined>, customPrompt? : string, filterFilledFields: boolean = true) {
259-
if (this.options.rateLimits && this.options.rateLimits.generateImages && await this.checkRateLimit("generateImages" ,this.options.rateLimits.generateImages, headers)) {
260-
jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
261-
return { error: "Rate limit exceeded" };
262-
}
261+
// TODO: need to do correct check of rate limit
262+
// if (this.options.rateLimits && this.options.rateLimits.generateImages && await this.checkRateLimit("generateImages" ,this.options.rateLimits.generateImages, headers)) {
263+
// jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
264+
// return { error: "Rate limit exceeded" };
265+
// }
263266
const selectedId = recordId;
264267
let isError = false;
265268
const start = +new Date();
@@ -369,10 +372,11 @@ export default class BulkAiFlowPlugin extends AdminForthPlugin {
369372
private async regenerateImage(jobId: string, recordId: string, fieldName: string, prompt: string, adminUser: any, headers: Record<string, string | string[] | undefined>) {
370373
const Id = recordId;
371374
let isError = false;
372-
if (await this.checkRateLimit(fieldName, this.options.generateImages[fieldName].rateLimit, headers)) {
373-
jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
374-
return { error: "Rate limit exceeded" };
375-
}
375+
// TODO: need to do correct check of rate limit
376+
// if (await this.checkRateLimit(fieldName, this.options.generateImages[fieldName].rateLimit, headers)) {
377+
// jobs.set(jobId, { status: 'failed', error: "Rate limit exceeded" });
378+
// return { error: "Rate limit exceeded" };
379+
// }
376380
const start = +new Date();
377381
const record = await this.adminforth.resource(this.resourceConfig.resourceId).get([Filters.EQ(this.resourceConfig.columns.find(c => c.primaryKey)?.name, Id)]);
378382
let attachmentFiles

0 commit comments

Comments
 (0)