fix: improve debugger snapshot handling and error message formatting

- Track stack depth for proper snapshot management in try-catch blocks
- Update error message format in catch blocks to include quotes
- Ensure proper cleanup of debugger snapshots for caught errors
- Update test cases to match new error message format

Author: dev-kas

evaluator/evalTryCatch.go

@@ -12,17 +12,30 @@ import (
 func evalTryCatch(node *ast.TryCatchStmt, env *environment.Environment, dbgr *debugger.Debugger) (*shared.RuntimeValue, *errors.RuntimeError) {
 	scope := environment.NewEnvironment(env)
 
+	// I realized that just removing the snapshot at catching the error
+	// is not enough, we have to make sure the call stack has the same
+	// length as things go in and out of this function, so that the snapshots
+	// isnt messed up. snapshots are meant to be taken only upon uncaught errors
+	// and not on caught errors
+	var stackDepth int
+	if dbgr != nil {
+		stackDepth = len(dbgr.CallStack)
+	}
+
 	for _, stmt := range node.Try {
+
 		_, err := Evaluate(stmt, &scope, dbgr)
 		if err != nil {
 			// Because we are successfully catching this error,
 			// we can safely delete the snapshot
+			// Here we will remove everything other than the stackDepth
+			// we saved earlier
 			if dbgr != nil && len(dbgr.Snapshots) > 0 {
-				dbgr.Snapshots = dbgr.Snapshots[:len(dbgr.Snapshots)-1]
+				dbgr.Snapshots = dbgr.Snapshots[:stackDepth]
 			}
 			scope = environment.NewEnvironment(env)
 
-			scope.DeclareVar(node.CatchVar, shared.RuntimeValue{Type: shared.String, Value: "Runtime Error: " + err.Message}, false)
+			scope.DeclareVar(node.CatchVar, shared.RuntimeValue{Type: shared.String, Value: "\"Runtime Error: " + err.Message + "\""}, false)
 
 			var lastResult *shared.RuntimeValue = nil
 			for _, stmt := range node.Catch {

evaluator/evaluator_test.go

@@ -1136,7 +1136,7 @@ func TestTryCatch(t *testing.T) {
 			input: "let error = 'error not triggered'\ntry {undefinedVariable} catch e {error = e}\nerror",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: Cannot resolve variable `undefinedVariable`",
+				Value: "\"Runtime Error: Cannot resolve variable `undefinedVariable`\"",
 			},
 		},
 		{
@@ -1157,14 +1157,14 @@ func TestTryCatch(t *testing.T) {
 			input: "let error = 'error not triggered'\ntry {let x = y} catch e {error = e}\nerror",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: Cannot resolve variable `y`",
+				Value: "\"Runtime Error: Cannot resolve variable `y`\"",
 			},
 		},
 		{
 			input: "let error = 'error not triggered'\ntry {let x = 10\nx = x + y} catch e {error = e}\nerror",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: Cannot resolve variable `y`",
+				Value: "\"Runtime Error: Cannot resolve variable `y`\"",
 			},
 		},
 		{
@@ -1178,7 +1178,7 @@ func TestTryCatch(t *testing.T) {
 			input: "let error = 'error not triggered'\ntry {let obj = {foo: 'bar'}\nobj.foo()} catch e {error = e}\nerror",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: Cannot invoke a non-function (attempted to call a string).",
+				Value: "\"Runtime Error: Cannot invoke a non-function (attempted to call a string).\"",
 			},
 		},
 		{
@@ -1192,7 +1192,7 @@ func TestTryCatch(t *testing.T) {
 			input: "let error = 'error not triggered'\ntry {let arr = [1, 2, 3]\narr.foo()} catch e {error = e}\nerror",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: Cannot access property of array by non-number (attempting to access properties by Identifier).",
+				Value: "\"Runtime Error: Cannot access property of array by non-number (attempting to access properties by Identifier).\"",
 			},
 		},
 		{
@@ -1473,7 +1473,7 @@ func TestContinueKeyword(t *testing.T) {
 			input: "let err = ''\ntry {continue} catch e {err = e}\nerr",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: `continue` statement used outside of a loop context.",
+				Value: "\"Runtime Error: `continue` statement used outside of a loop context.\"",
 			},
 		},
 	}
@@ -1647,7 +1647,7 @@ func TestBreakKeyword(t *testing.T) {
 			input: "let err = ''\ntry {break} catch e {err = e}\nerr",
 			output: shared.RuntimeValue{
 				Type:  shared.String,
-				Value: "Runtime Error: `break` statement used outside of a loop context.",
+				Value: "\"Runtime Error: `break` statement used outside of a loop context.\"",
 			},
 		},
 	}