Skip to content

Commit 97a32fc

Browse files
rfayclaude
andcommitted
ci: fix DDEV test step gating and cleanup command, for #71
- Gate DDEV start/check/cleanup on matrix.app_slug so freeform skips them - Replace bash -c cd+ddev-delete with ddev delete <project-name> which works from any directory, avoiding coder ssh argument quoting issues Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 47f532f commit 97a32fc

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/integration-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ jobs:
146146
echo "HOST_DIR=/coder-workspaces/${OWNER}-${{ env.WORKSPACE_NAME }}" >> "$GITHUB_ENV"
147147
148148
- name: Verify workspace — DDEV can start a project
149+
if: ${{ matrix.app_slug != '' }}
149150
run: |
150151
# Write start script to runner-local file so we avoid the coder ssh heredoc+PTY hang
151152
cat > /tmp/ci-ddev-start-${{ github.run_id }}.sh << 'EOF'
@@ -180,11 +181,10 @@ jobs:
180181
[[ "$STATUS" =~ ^[2-4] ]] || { echo "ERROR: unexpected HTTP status $STATUS" >&2; exit 1; }
181182
182183
- name: Cleanup DDEV test project
184+
if: ${{ matrix.app_slug != '' }}
183185
run: |
184-
coder ssh ${{ env.WORKSPACE_NAME }} -- \
185-
env CI=${{ env.CI }} DDEV_NONINTERACTIVE=${{ env.DDEV_NONINTERACTIVE }} NO_COLOR=${{ env.NO_COLOR }} \
186-
bash -c "cd /tmp/ci-ddev-${{ github.run_id }} && ddev delete --omit-snapshot -y && rm -rf /tmp/ci-ddev-${{ github.run_id }}" \
187-
< /dev/null
186+
coder ssh ${{ env.WORKSPACE_NAME }} -- ddev delete ci-ddev-${{ github.run_id }} --omit-snapshot -y < /dev/null || true
187+
coder ssh ${{ env.WORKSPACE_NAME }} -- rm -rf /tmp/ci-ddev-${{ github.run_id }} < /dev/null || true
188188
189189
- name: Delete workspace
190190
if: always()

0 commit comments

Comments
 (0)