Improve splash screen behavior

Author: danielsaidi

Demo/Demo/ContentView.swift

@@ -33,18 +33,18 @@ struct ContentView: View {
                     }
                 }
             }
-            .navigationTitle("Demo")
+            .navigationTitle("VideoKit")
             .fullScreenCover(item: $selection) { sampleVideo in
                 videoPlayer(for: sampleVideo)
             }
             .toolbar {
                 ToolbarItem(placement: .primaryAction) {
                     Menu {
-                        Toggle("Launch Video", isOn: $isVideoSplashScreenEnabled)
-                        Section {
+                        Toggle("Splash Video", isOn: $isVideoSplashScreenEnabled)
+                        Section("List") {
                             Picker("Video Mode", selection: $videoMode) {
-                                Text("Modal Videos").tag(VideoMode.modal)
-                                Text("Inline Videos").tag(VideoMode.inline)
+                                Text("List Videos").tag(VideoMode.modal)
+                                Text("List Previews").tag(VideoMode.inline)
                             }
                         }
                     } label: {
@@ -56,8 +56,7 @@ struct ContentView: View {
         }
         .task { fetchSampleVideos() }
         .videoSplashScreen(
-            videoURL: videoSplashUrl,
-            isEnabled: isVideoSplashScreenEnabled,
+            videoURL: isVideoSplashScreenEnabled ? videoSplashUrl : nil,
             configuration: .demo,
             videoPlayerView: { videoPlayer in
                 ZStack {

RELEASE_NOTES.md

@@ -10,6 +10,14 @@ Until then, breaking changes can happen in any minor version.
 
 This version bumps the package to Swift 6.1 and the demo app to iOS 26.
 
+### 💡 Adjustments
+
+* `VideoSplashScreenViewModifier` now avoids redrawing the source view.
+
+### 💥 Breaking Changes
+
+* `VideoSplashScreenViewModifier` no longer has an enabled property.
+
 
 
 ## 0.3

Sources/VideoKit/Splash/VideoSplashScreenViewModifier.swift

@@ -86,16 +86,18 @@ public struct VideoSplashScreenViewModifier<VideoPlayerView: View>: ViewModifier
 private extension VideoSplashScreenViewModifier {
 
     @ViewBuilder var playerView: some View {
-        videoPlayerView(
-            VideoPlayer(
-                videoURL: videoURL,
-                controllerConfiguration: { controller in
-                    controller.showsPlaybackControls = false
-                },
-                didPlayToEndAction: dismissSplashScreen
+        if let videoURL {
+            videoPlayerView(
+                VideoPlayer(
+                    videoURL: videoURL,
+                    controllerConfiguration: { controller in
+                        controller.showsPlaybackControls = false
+                    },
+                    didPlayToEndAction: dismissSplashScreen
+                )
             )
-        )
-        .ignoresSafeArea()
+            .ignoresSafeArea()
+        }
     }
 }
 
@@ -139,43 +141,39 @@ public extension VideoSplashScreenConfiguration {
 
 public extension View {
 
-    /// Apply a video splash screen that uses a plain ``VideoPlayer`` view.
+    /// Apply a video splash screen that uses a plain ``VideoPlayer`` view
+    /// and a standard configuration.
     ///
     /// The splash screen will be presented when the view is loaded and dismiss
     /// itself to reveal the underlying view once the video finishes playing.
     ///
     /// - Parameters:
-    ///   - videoURL: The video URL to play.
-    ///   - isEnabled: Whether the splash screen is enabled, by default `true`.
-    ///   - configuration: The configuration to apply, by default ``VideoSplashScreenConfiguration/standard``.
+    ///   - videoURL: The video URL to play, if any.
     @ViewBuilder
     func videoSplashScreen(videoURL: URL?) -> some View {
         self.videoSplashScreen(
             videoURL: videoURL,
-            isEnabled: true,
             configuration: nil,
             videoPlayerView: { $0 }
         )
     }
 
-    /// Apply a video splash screen that uses a plain ``VideoPlayer`` view.
+    /// Apply a video splash screen that uses a plain ``VideoPlayer`` view
+    /// and a custom configuration.
     ///
     /// The splash screen will be presented when the view is loaded and dismiss
     /// itself to reveal the underlying view once the video finishes playing.
     ///
     /// - Parameters:
-    ///   - videoURL: The video URL to play.
-    ///   - isEnabled: Whether the splash screen is enabled, by default `true`.
-    ///   - configuration: The configuration to apply, by default ``VideoSplashScreenConfiguration/standard``.
+    ///   - videoURL: The video URL to play, if any.
+    ///   - configuration: The configuration to apply.
     @ViewBuilder
     func videoSplashScreen(
         videoURL: URL?,
-        isEnabled: Bool = true,
         configuration: VideoSplashScreenConfiguration
     ) -> some View {
         self.videoSplashScreen(
             videoURL: videoURL,
-            isEnabled: isEnabled,
             configuration: configuration,
             videoPlayerView: { $0 }
         )
@@ -187,28 +185,22 @@ public extension View {
     /// itself to reveal the underlying view once the video finishes playing. 
     ///
     /// - Parameters:
-    ///   - videoURL: The video URL to play.
-    ///   - isEnabled: Whether the splash screen is enabled, by default `true`.
+    ///   - videoURL: The video URL to play, if any.
     ///   - configuration: The configuration to apply, by default ``VideoSplashScreenConfiguration/standard``.
     ///   - videoPlayerView: A custom video player content builder.
     @ViewBuilder
     func videoSplashScreen<VideoPlayerView: View>(
         videoURL: URL?,
-        isEnabled: Bool = true,
         configuration: VideoSplashScreenConfiguration? = nil,
         @ViewBuilder videoPlayerView: @escaping (VideoPlayer) -> VideoPlayerView
     ) -> some View {
-        if isEnabled {
-            self.modifier(
-                VideoSplashScreenViewModifier(
-                    videoURL: videoURL,
-                    configuration: configuration,
-                    videoPlayerView: videoPlayerView
-                )
+        self.modifier(
+            VideoSplashScreenViewModifier(
+                videoURL: videoURL,
+                configuration: configuration,
+                videoPlayerView: videoPlayerView
             )
-        } else {
-            self
-        }
+        )
     }
 }