Remove check for docblock when trying to find parent entities (#55)

Co-authored-by: Maxim Smakouz <m.smakouz@gmail.com>

Author: makedo

src/Utils/EntityUtils.php

@@ -48,10 +48,6 @@ public function findParent(string $class, bool $root = true): ?string
                 continue;
             }
 
-            if ($class->getDocComment() === false) {
-                continue;
-            }
-
             $ann = $this->reader->firstClassMetadata($class, Entity::class);
             if ($ann !== null) {
                 return $parent;

tests/Annotated/Fixtures/Fixtures22/Annotated/LocalManager.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Annotated;
+
+use Cycle\Annotated\Annotation\Entity;
+
+/** @Entity*/
+class LocalManager extends LocalSupplier
+{
+}

tests/Annotated/Fixtures/Fixtures22/Annotated/LocalSupplier.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Annotated;
+
+use Cycle\Annotated\Annotation\Entity;
+
+/** @Entity */
+class LocalSupplier extends Supplier
+{
+}

tests/Annotated/Fixtures/Fixtures22/Annotated/Person.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Annotated;
+
+use Cycle\Annotated\Annotation\Entity;
+
+/** @Entity */
+class Person
+{
+}

tests/Annotated/Fixtures/Fixtures22/Annotated/Supplier.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Annotated;
+
+class Supplier extends Person
+{
+}

tests/Annotated/Fixtures/Fixtures22/Attributed/LocalManager.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Attributed;
+
+use Cycle\Annotated\Annotation\Entity;
+
+#[Entity]
+class LocalManager extends LocalSupplier
+{
+}

tests/Annotated/Fixtures/Fixtures22/Attributed/LocalSupplier.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Attributed;
+
+use Cycle\Annotated\Annotation\Entity;
+
+#[Entity]
+class LocalSupplier extends Supplier
+{
+}

tests/Annotated/Fixtures/Fixtures22/Attributed/Person.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Attributed;
+
+use Cycle\Annotated\Annotation\Entity;
+
+#[Entity]
+class Person
+{
+}

tests/Annotated/Fixtures/Fixtures22/Attributed/Supplier.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Fixtures\Fixtures22\Attributed;
+
+class Supplier extends Person
+{
+}

tests/Annotated/Unit/Utils/EntityUtilsTest.php

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Cycle\Annotated\Tests\Unit\Utils;
+
+use Cycle\Annotated\Utils\EntityUtils;
+use PHPUnit\Framework\TestCase;
+use Spiral\Attributes\AnnotationReader;
+use Spiral\Attributes\AttributeReader;
+use Spiral\Attributes\ReaderInterface;
+
+class EntityUtilsTest extends TestCase
+{
+    /**
+     * @dataProvider findParentDataProvider
+     */
+    public function testFindParent(
+        ReaderInterface $reader,
+        string $child,
+        bool $root,
+        ?string $expectedParent
+    ): void {
+        $entityUtils = new EntityUtils($reader);
+
+        $actualParent = $entityUtils->findParent($child, $root);
+
+        $this->assertEquals($expectedParent, $actualParent);
+    }
+
+    public function findParentDataProvider(): iterable
+    {
+        $namespace = 'Cycle\Annotated\Tests\Fixtures\Fixtures22';
+        $readers = [
+            'Attributed' => new AttributeReader(),
+            'Annotated' => new AnnotationReader(),
+        ];
+
+        foreach ($readers as $readerType => $reader) {
+            yield "$readerType Child Root"
+                => [$reader, "$namespace\\$readerType\\Person", true, null];
+            yield "$readerType Child Not Root"
+                => [$reader, "$namespace\\$readerType\\Person", false, null];
+
+            yield "$readerType 1st Level Root"
+                => [$reader, "$namespace\\$readerType\\Supplier", true, "$namespace\\$readerType\\Person"];
+            yield "$readerType 1st Level Not Root"
+                => [$reader, "$namespace\\$readerType\\Supplier", false, "$namespace\\$readerType\\Person"];
+
+            yield "$readerType 2nd Level Root"
+                => [$reader, "$namespace\\$readerType\\LocalSupplier", true, "$namespace\\$readerType\\Person"];
+            yield "$readerType 2nd Level Root No Entity Attribute"
+                => [$reader, "$namespace\\$readerType\\LocalSupplier", false, "$namespace\\$readerType\\Person"];
+
+            yield "$readerType 3rd Level Root"
+                => [$reader, "$namespace\\$readerType\\LocalManager", true, "$namespace\\$readerType\\Person"];
+            yield "$readerType 3rd Level Not Root"
+                => [$reader, "$namespace\\$readerType\\LocalManager", false, "$namespace\\$readerType\\LocalSupplier"];
+        }
+    }
+}