cosmovisor: wrong check for upgrade height

[0114kek]

In checkHeight function in scanner.go
It compares current height with upgrade height

// scanner.go line 166
currentHeight, err := fw.checkHeight()
	if (err != nil || currentHeight < info.Height) && !errors.Is(err, errUntestAble) {
		return false
	}

But when it reaches the upgrade height, currentHeight alwaysinfo.Heigh -1, leading to CheckUpdate function always return false. Because chain should be panicked in the process of block is finalized

[linear]

SDK-470

[aaronc]

In #25874, this issue as well as several known issues with the current version of Cosmovisor should be addressed.

[aayushbaluni]

Fix submitted in #26105. Root cause: when the chain panics during block finalization at upgrade height, the status endpoint returns the last committed block (info.Height-1); the check currentHeight < info.Height incorrectly rejected this case. The fix uses minHeight = info.Height - 1 so cosmovisor proceeds when ready.

[SillyZir]

The comparison should be currentHeight < info.Height - 1 or equivalently <= with adjusted semantics, since the node halts during finalization of the upgrade block and never reports info.Height via RPC.