Adjust access to env variables for GH workflows

Author: annda

.github/workflows/release.yml

@@ -1,14 +1,11 @@
-name: Create Release
+name: Test and Create Release
 
 on:
   push:
-    tags:
-      - 'v*'
-  # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
 
 env:
-  DATA_DIR: cypress/yaml
+  DATA_DIR: 'cypress/yaml'
   CYPRESS_BASE_URL: "http://localhost:8181"
 
 jobs:
@@ -25,6 +22,14 @@ jobs:
           node-version: 23
       - run: npm ci
       - run: npm run build --if-present
+      - name: PHP env check
+        run: |
+          php -r '
+            $edd = $_ENV["DATA_DIR"] ?? "--nonexistent--";
+            $gdd = getenv("DATA_DIR") ?? "--nonexistent--";
+            echo "S_ENV variable DATA_DIR is: " . $edd . "\n";
+            echo "getenv variable DATA_DIR is:" . $gdd . "\n";
+          '
       - name: Cypress run
         uses: cypress-io/github-action@v6
         with:

app/settings.php

@@ -15,8 +15,10 @@
     }
 
     // finally merge from environment
-    if (!empty($_ENV['DATA_DIR'])) {
-        $settings['settings']['dataDir'] = $_ENV['DATA_DIR'];
+    // dotenv loads .env files and env variables - in that order
+    // using getenv() since $_ENV is not available in (at least some) GitHub runners
+    if (!empty(getenv('DATA_DIR'))) {
+        $settings['settings']['dataDir'] = getenv('DATA_DIR');
     }
 
     $containerBuilder->addDefinitions($settings);

public/index.php

@@ -18,8 +18,9 @@
     $containerBuilder->enableCompilation(ROOT_DIR . 'var/cache');
 }
 
-// Load .env file
-$dotenv = Dotenv\Dotenv::createImmutable(ROOT_DIR);
+// Load .env file and env variables
+// unsafe because we need getenv(), $_ENV is not available in Github runners
+$dotenv = Dotenv\Dotenv::createUnsafeImmutable(ROOT_DIR);
 $dotenv->safeLoad();
 
 // Set up settings