fix(ui): use solid glyphs + coloured disc for box/party legality indicator

Closes #724.

f254c20 fixed this for the Trade tab but the same pattern was never
applied to PokemonSlotComponent (box + party views), so the Filled
CheckCircle / Warning / Cancel cutouts returned as soon as a save was
loaded. Mirror the Trade fix here: swap to solid Check / PriorityHigh /
Close glyphs drawn white over a coloured wrapper disc.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: codemonkey85

Pkmds.Rcl/Components/PokemonSlotComponent.razor

@@ -65,7 +65,12 @@
 
             @if (!AppState.IsHaXEnabled && GetLegalityStatus() is { } status)
             {
-                <div class="legality-indicator-icon"
+                <div class="@($"legality-indicator-icon {status switch
+                            {
+                                LegalityStatus.Legal => "legality-indicator-icon--legal",
+                                LegalityStatus.Fishy => "legality-indicator-icon--fishy",
+                                _ => "legality-indicator-icon--illegal"
+                            }}")"
                      title="@(status switch
                             {
                                 LegalityStatus.Legal => "Legal",
@@ -74,18 +79,11 @@
                             })">
                     <MudIcon Icon="@(status switch
                                    {
-                                       LegalityStatus.Legal => Icons.Material.Filled.CheckCircle,
-                                       LegalityStatus.Fishy => Icons.Material.Filled.Warning,
-                                       _ => Icons.Material.Filled.Cancel
+                                       LegalityStatus.Legal => Icons.Material.Filled.Check,
+                                       LegalityStatus.Fishy => Icons.Material.Filled.PriorityHigh,
+                                       _ => Icons.Material.Filled.Close
                                    })"
-                             Color="@(status switch
-                                    {
-                                        LegalityStatus.Legal => Color.Success,
-                                        LegalityStatus.Fishy => Color.Warning,
-                                        _ => Color.Error
-                                    })"
-                             Class="w-full h-full"
-                             Style="font-size: 16px;"/>
+                             Style="font-size: 14px; color: white;"/>
                 </div>
             }