fix tests with plugins as dependencies

Author: sdepassio

.github/scripts/list-plugins-to-build-and-test.py

@@ -43,14 +43,22 @@ def add_package_info(packaging_file, build=True, test=True):
                             if line.startswith("package "):
                                 plugin_package_name = line.split()[1].replace(";", "")
                                 break
+        packaging_dir = Path(packaging_file).parent
+        test_dependencies = []
+        rpm_file = f'{packaging_dir}/rpm.json'
+        if rpm_file.exists():
+            with open(rpm_file) as rf:
+                rpm_data = json.load(rf)
+                test_dependencies = [dependency for dependency in rpm_data.get('dependencies', []) if dependency.lower().startswith('centreon-plugin-')]
         if packaging['pkg_name'] not in list_plugins:
             list_plugins[packaging['pkg_name']] = {
                 "perl_package": plugin_package_name,
                 "command": packaging['plugin_name'],
                 "paths": plugin_paths,
                 "build": build,
                 "test": test,
-                "runner_id": runner_id
+                "runner_id": runner_id,
+                "test_dependencies": test_dependencies
             }
             if runner_id == max_runners:
                 runner_id = 1

.github/scripts/test-plugins.py

@@ -47,7 +47,18 @@ def refresh_packet_manager(archi, logs_dir):
 
 
 # Install plugin, from local file if build is true, from repository if false.
-def install_plugin(plugin, archi, build, logs_dir):
+def install_plugin(plugin, archi, build, logs_dir, dependencies=None):
+    if dependencies:
+        for dep in dependencies:
+            if archi == "deb":
+                local_exists = len(glob.glob(f"./{dep.lower()}*.deb")) > 0
+            else:
+                local_exists = len(glob.glob(f"./{dep}*.rpm")) > 0
+            if local_exists:
+                print(f"Installing test dependency {dep} for {plugin}")
+                dep_status = install_plugin(dep, archi, True, logs_dir)
+                if dep_status != 0:
+                    print(f"Warning: failed to install test dependency {dep} for {plugin}")
     with open(f'{logs_dir}/test-plugins-installation.log', "a") as outfile:
         if archi == "deb":
             if build:
@@ -177,13 +188,13 @@ def remove_plugin(plugin, archi, logs_dir):
     parser.add_argument('--runner-id', type=int, help='ID du runner pour le test des plugins')
     parser.add_argument('--logs-dir', type=str, help='Répertoire des logs', default='/var/log')
     parser.add_argument('--reports-dir', type=str, help='Répertoire des rapports', default='reports')
-    parser.add_argument('--skip-robot-tests', type=bool, help='True to skip robot tests, default value: False', default=False)
+    parser.add_argument('--skip-robot-tests', type=str, help='True to skip robot tests, default value: False', default='false')
     args = parser.parse_args()
 
     launch_snmp_sim()
     archi = args.extension  # expected either deb or rpm.
     logs_dir = args.logs_dir
-    skip_robot_tests = args.skip_robot_tests
+    skip_robot_tests = args.skip_robot_tests.lower() == 'true'
     if args.runner_id:
         logs_dir = os.path.join(logs_dir, f"runner-{args.runner_id}")
     os.makedirs(logs_dir, exist_ok=True)
@@ -213,7 +224,9 @@ def remove_plugin(plugin, archi, logs_dir):
             print("Testing plugin : ", plugin)
 
             nb_plugins += 1
-            tmp = install_plugin(plugin, archi, plugins[plugin]["build"], logs_dir)
+
+            test_deps = plugins[plugin].get("test_dependencies", [])
+            tmp = install_plugin(plugin, archi, plugins[plugin]["build"], logs_dir, test_deps)
             if tmp > 0:
                 error_install += 1
                 list_plugin_error.add(plugin)

.github/workflows/plugins.yml

@@ -364,8 +364,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        #image: [testing-plugins-alma8, testing-plugins-alma9, testing-plugins-alma10, testing-plugins-jammy, testing-plugins-bullseye, testing-plugins-bookworm, testing-plugins-trixie, testing-plugins-noble, testing-plugins-bullseye-arm64]
-        image: [testing-plugins-alma8, testing-plugins-alma9, testing-plugins-jammy, testing-plugins-bullseye, testing-plugins-bookworm, testing-plugins-noble, testing-plugins-bullseye-arm64]
+        image: [testing-plugins-alma8, testing-plugins-alma9, testing-plugins-alma10, testing-plugins-jammy, testing-plugins-bullseye, testing-plugins-bookworm, testing-plugins-trixie, testing-plugins-noble, testing-plugins-bullseye-arm64]
         include:
           - skip_robot_tests: false
           - package_extension: rpm
@@ -419,6 +418,7 @@ jobs:
       package-extension: ${{ matrix.package_extension }}
       packages-cache-key: ${{ github.sha }}-${{ github.run_id }}-${{ matrix.package_extension }}-${{ matrix.distrib }}
       plugins-json-cache-key: plugins-${{ github.sha }}-${{ github.run_id }}
+      skip-robot-tests: ${{ matrix.skip_robot_tests }}
     secrets:
       registry_username: ${{ secrets.HARBOR_CENTREON_PULL_USERNAME }}
       registry_password: ${{ secrets.HARBOR_CENTREON_PULL_TOKEN }}