Skip to content

Dedupe String Processor is not used when there is no dedupe string override #722

Description

@andrewdodd13

Hey team, I'm trying to combine monitorCustom with a custom IAlarmDedupeStringProcessor. I am running into an issue that my custom dedupe string processor is not being invoked. The root cause seems to be that unless I set a dedupe string on every single addAlarm entry, my custom dedupe string processor isn't invoked. This is annoying, because my dedupe string processor just returns a fixed string unless there's an override set.

* If a dedupe string strategy is set, it will be used to process the final string.

I am not sure how we can fix this particularly well. The string passed to the dedupe string processor must not be undefined, otherwise we could pass undefined in and let the processor deal with it.

I could sub-class and override the Alarm Naming Strategy, but this changes the alarm names globally and thus loses the local prefix which is added by e.g. DynamoDB table monitoring which sets the suffix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions