fix: consider elements with attributes & no text to be empty

Author: phette23

collection-export/strict-mods-helpers.js

@@ -172,18 +172,13 @@ export function createElement(doc, elementName, textContent = '', attributes = {
 }
 
 /**
- * Check if an element is truly empty (no attributes, no text, all children empty)
+ * Check if an element is truly empty (no text, all children empty)
  * Used by removeEmptyElements - extracted for reusability
  *
  * @param {Element} element - Element to check
  * @returns {boolean} True if element is completely empty
  */
 export function isElementEmpty(element) {
-    // Has attributes? Not empty
-    if (element.attributes && element.attributes.length > 0) {
-        return false
-    }
-
     // Check all child nodes
     for (let node of element.childNodes) {
         if (node.nodeType === 3) { // TEXT_NODE
@@ -197,49 +192,5 @@ export function isElementEmpty(element) {
         }
     }
 
-    return true // No attributes, no text, all children empty
-}
-
-/**
- * Iterative alternative to recursive removeEmptyElements
- * More efficient for very large or deeply nested documents
- *
- * @param {Document} doc - XML DOM document
- * @param {string} [rootPath='//mods'] - XPath to root elements to clean
- * @returns {Document} Modified document
- */
-export function removeEmptyElementsIterative(doc, rootPath = '//mods') {
-    if (!doc) {
-        return doc
-    }
-
-    const modsElements = safeSelect(rootPath, doc)
-
-    for (let root of modsElements) {
-        // Collect all elements to check (bottom-up)
-        const elementsToCheck = []
-        const stack = [root]
-
-        while (stack.length > 0) {
-            const current = stack.pop()
-            elementsToCheck.push(current)
-
-            // Add children to stack (in reverse order for correct processing)
-            const children = Array.from(current.childNodes)
-                .filter(n => n.nodeType === 1)
-                .reverse()
-            stack.push(...children)
-        }
-
-        // Process bottom-up (children before parents)
-        elementsToCheck.reverse()
-
-        for (let element of elementsToCheck) {
-            if (isElementEmpty(element) && element.parentNode && element !== root) {
-                element.parentNode.removeChild(element)
-            }
-        }
-    }
-
-    return doc
+    return true // No text, all children empty
 }

collection-export/strict-mods.js

@@ -238,14 +238,14 @@ export function renameElement(doc, oldName, newName, xpathContext = XPATH_CONTEX
     for (let element of elements) {
         const newElement = doc.createElement(newName)
         copyAttributes(element, newElement)
-        
+
         // Add new attributes if specified
         if (attributes && typeof attributes === 'object') {
             Object.entries(attributes).forEach(([name, value]) => {
                 newElement.setAttribute(name, value)
             })
         }
-        
+
         moveChildren(element, newElement)
         element.parentNode.replaceChild(newElement, element)
     }
@@ -254,7 +254,7 @@ export function renameElement(doc, oldName, newName, xpathContext = XPATH_CONTEX
 }
 
 /**
- * Recursively remove empty elements (no attributes, no text, no meaningful children)
+ * Recursively remove empty elements (no text, no children with text)
  * This prevents validation errors from empty required elements and cleans up output
  *
  * @param {Document} doc - XML DOM document
@@ -525,13 +525,13 @@ export function convertNamePartDate(doc) {
     for (let element of namePartDates) {
         const newElement = doc.createElement('namePart')
         newElement.setAttribute('type', 'date')
-        
+
         // Copy attributes from original element
         copyAttributes(element, newElement)
-        
+
         // Move children (text nodes and elements)
         moveChildren(element, newElement)
-        
+
         // Replace the old element with the new one
         element.parentNode.replaceChild(newElement, element)
     }
@@ -632,7 +632,7 @@ export function toStrictMODS(xmlString) {
     // Remove non-standard attributes
     removeAttribute(doc, XPATH_CONTEXTS.ACCESS_CONDITION, 'href')
 
-    // Remove all empty elements (no attributes, no text, no meaningful children)
+    // Remove all empty elements (no text, no children with text)
     removeEmptyElements(doc)
 
     // Extract mods element and add namespace (for validation)