feat: nameIdentifier@type=email for usernames, ref #115

Author: phette23

collection-export/fixtures/syllabus-one-faculty.mods.xml

@@ -1,7 +1,7 @@
 <mods xmlns="http://www.loc.gov/mods/v3" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     version="3.8"
     xsi:schemaLocation="http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-8.xsd">
-
+    <!-- this is just an example of what output should look like and not used in any tests -->
     <titleInfo>
         <title>FASHN-360 Media History</title>
         <partNumber>Fall 2026</partNumber>
@@ -14,13 +14,14 @@
         <role>
             <roleTerm authority="marcrelator" authorityURI="http://id.loc.gov/vocabulary/relators" valueURI="http://id.loc.gov/vocabulary/relators/tch">teacher</roleTerm>
         </role>
+        <nameIdentifier type="email" typeURI="https://datatracker.ietf.org/doc/html/rfc5322" displayLabel="Email">ephetteplace@cca.edu</nameIdentifier>
     </name>
 
     <name type="corporate">
         <namePart>Design Division</namePart>
         <namePart>Fasion Design (BFA)</namePart>
         <role>
-            <roleTerm type="text" authority="marcrelator">sponsor</roleTerm>
+            <roleTerm authority="marcrelator" authorityURI="http://id.loc.gov/vocabulary/relators" valueURI="http://id.loc.gov/vocabulary/relators/spn">sponsor</roleTerm>
         </role>
     </name>
 

collection-export/syllabus.js

@@ -8,8 +8,6 @@ import {
 } from './xml-helpers.js'
 import {convertPartNumbers, moveAndRenameElement, removeEmptyElements} from './strict-mods.js'
 
-// TODO handle username as nameIdentifier
-
 /**
  * Add a role/roleTerm child to a parent element assuming marcrelator authority.
  * Used by personalNames and corporateName functions.
@@ -101,6 +99,27 @@ export function personalNames(doc) {
         })
     }
 
+    // usernames list -> nameIdentifier elements
+    const facultyID = safeSelectFirst("//local/courseInfo/facultyID", doc)
+    const usernames = facultyID ? facultyID.textContent.split(', ')
+        .map(id => id.trim())
+        .filter(id => id.length > 0) : []
+    const nameElements = safeSelect("//mods/name[@type='personal']", doc)
+
+    // sanity check: only add nameIdentifier if we have the same number of usernames as names
+    if (usernames.length !== nameElements.length) {
+        return doc
+    }
+
+    for (let i = 0; i < usernames.length; i++) {
+        const nameIdentifier = createElement(doc, 'nameIdentifier')
+        nameIdentifier.setAttribute('type', 'email')
+        nameIdentifier.setAttribute('typeURI', 'https://datatracker.ietf.org/doc/html/rfc5322')
+        nameIdentifier.setAttribute('displayLabel', 'Email')
+        nameIdentifier.textContent = `${usernames[i]}@cca.edu`
+        nameElements[i].appendChild(nameIdentifier)
+    }
+
     return doc
 }
 

collection-export/syllabus.test.js

@@ -87,6 +87,39 @@ describe('personalNames', () => {
         assert.ok(namePart2)
         assert.strictEqual(namePart2.textContent, 'Jane Smith')
     })
+
+    it('should add an email nameIdentifier for each personal name if local/facultyID is present', async () => {
+        const inputXML = x(`<local><courseInfo><faculty>John Doe, Jane Smith</faculty><facultyID>jdoe, jsmith</facultyID></courseInfo></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const nameElements = xpath.select('//mods/name[@type="personal"]', result)
+        assert.strictEqual(nameElements.length, 2)
+        const nameIdentifiers = xpath.select('//mods/name[@type="personal"]/nameIdentifier', result)
+        assert.strictEqual(nameIdentifiers.length, 2)
+        assert.ok(nameIdentifiers[0])
+        assert.strictEqual(nameIdentifiers[0].textContent, 'jdoe@cca.edu')
+        assert.ok(nameIdentifiers[1])
+        assert.strictEqual(nameIdentifiers[1].textContent, 'jsmith@cca.edu')
+    })
+
+    it('should not add email nameIdentifiers if local/facultyID is missing', async () => {
+        const inputXML = x(`<local><courseInfo><faculty>John Doe, Jane Smith</faculty></courseInfo></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const nameElements = xpath.select('//mods/name[@type="personal"]', result)
+        assert.strictEqual(nameElements.length, 2)
+        const nameIdentifier1 = xpath.select1('nameIdentifier', nameElements[0])
+        assert.ok(!nameIdentifier1)
+        const nameIdentifier2 = xpath.select1('nameIdentifier', nameElements[1])
+        assert.ok(!nameIdentifier2)
+    })
+
+    it('should not add emails if they do not correspond with names', async () => {
+        const inputXML = x(`<local><courseInfo><faculty>John Doe</faculty><facultyID>jdoe, jsmith</facultyID></courseInfo></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const nameElements = xpath.select('//mods/name[@type="personal"]', result)
+        assert.strictEqual(nameElements.length, 1)
+        const nameIdentifier1 = xpath.select1('nameIdentifier', nameElements[0])
+        assert.ok(!nameIdentifier1)
+    })
 })
 
 describe('corporateName', () => {