feat: course & section code identifiers, ref #115

also wrap some if statement in hasDirectText to avoid problems with empty elements

Author: phette23

collection-export/syllabus.js

@@ -31,6 +31,36 @@ export function addGenre(doc) {
     return doc
 }
 
+/**
+ * local/courseInfo/courseName -> mods/identifier[@type="course number"]
+ * local/courseInfo/section -> mods/identifier[@type="section"]
+ *
+ * @param   {Document}  doc  XML document
+ *
+ * @returns  {Document}       transformed document
+ */
+function addIdentifiers(doc) {
+    const courseCode = safeSelectFirst("//local/courseInfo/courseName", doc)
+    const sectionCode = safeSelectFirst("//local/courseInfo/section", doc)
+    const mods = safeSelectFirst("//mods", doc)
+
+    if (hasDirectTextContent(courseCode)) {
+        const identifier = createElement(doc, 'identifier')
+        identifier.setAttribute('type', 'course number')
+        identifier.textContent = courseCode.textContent
+        mods.appendChild(identifier)
+    }
+
+    if (hasDirectTextContent(sectionCode)) {
+        const identifier = createElement(doc, 'identifier')
+        identifier.setAttribute('type', 'section')
+        identifier.textContent = sectionCode.textContent
+        mods.appendChild(identifier)
+    }
+
+    return doc
+}
+
 /**
  * semester -> mods/subject/temporal
  * local/department -> strip degree postfix -> mods/subject/topic
@@ -43,7 +73,7 @@ export function addSubjects(doc) {
     const department = safeSelectFirst("//local/department", doc)
     const mods = safeSelectFirst("//mods", doc)
 
-    if (semester) {
+    if (hasDirectTextContent(semester)) {
         const temporal = createElement(doc, 'temporal')
         temporal.textContent = semester.textContent
         let subjectParent = safeSelectFirst("//mods/subject", doc)
@@ -54,7 +84,7 @@ export function addSubjects(doc) {
         subjectParent.appendChild(temporal)
     }
 
-    if (department) {
+    if (hasDirectTextContent(department)) {
         // TODO we could have a better map of department names to subject terms with URIs
         // TODO terms like "Individualized" are not informative
         const topic = createElement(doc, 'topic')
@@ -160,11 +190,9 @@ export function convertSyllabusXMLtoMODS(xmlString) {
     // mods/part/number to part/text @type=attachment-uuid
     convertPartNumbers(doc)
 
-    // Add syllabi genre
     addGenre(doc)
-
-    // Add subjects
     addSubjects(doc)
+    addIdentifiers(doc)
 
     // Remove empty elements last, after all transformations are complete
     removeEmptyElements(doc)

collection-export/syllabus.test.js

@@ -6,6 +6,21 @@ import {convertSyllabusXMLtoMODS} from './syllabus.js'
 // helper function to wrap XML in a root </xml> element
 const x = (xml) => `<xml>${xml}</xml>`
 
+describe('addIdentifiers', () => {
+    it('should add course number and section identifiers', async () => {
+        const courseNumber = 'ARTED-101'
+        const section = 'ARTED-101-1'
+        const inputXML = x(`<local><courseInfo><courseName>${courseNumber}</courseName><section>${section}</section></courseInfo></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const courseIdentifier = xpath.select1('//mods/identifier[@type="course number"]', result)
+        assert.ok(courseIdentifier)
+        assert.strictEqual(courseIdentifier.textContent, courseNumber)
+        const sectionIdentifier = xpath.select1('//mods/identifier[@type="section"]', result)
+        assert.ok(sectionIdentifier)
+        assert.strictEqual(sectionIdentifier.textContent, section)
+    })
+})
+
 describe('addSubjects', () => {
     it('should add a temporal subject for semester', async () => {
         const semester = 'Fall 2026'