feat: add syllabi subjects

temporal is semester, topic is department
this also improves the genre element with better attributes
and does some slight refactors elsewhere

Author: phette23

collection-export/syllabus.js

@@ -13,16 +13,64 @@ import {
 } from './xml-helpers.js'
 import {convertPartNumbers, moveAndRenameElement, removeEmptyElements} from './strict-mods.js'
 
+/**
+ * Adds a static mods/genre = 'syllabi' element
+ *
+ * @param   {Document}  doc  XML document
+ * @returns  {Document}       transformed document
+ */
 export function addGenre(doc) {
     const genre = createElement(doc, 'genre')
-    genre.setAttribute('type', 'aat')
+    genre.setAttribute('authority', 'aat')
+    genre.setAttribute('authorityURI', 'http://vocab.getty.edu/aat/')
+    genre.setAttribute('valueURI', 'http://vocab.getty.edu/aat/300028026')
     genre.textContent = 'syllabi'
     const mods = safeSelectFirst("//mods", doc)
     mods.appendChild(genre)
 
     return doc
 }
 
+/**
+ * semester -> mods/subject/temporal
+ * local/department -> strip degree postfix -> mods/subject/topic
+ *
+ * @param   {Document}  doc  XML document
+ * @returns  {Document}       transformed document
+ */
+export function addSubjects(doc) {
+    const semester = safeSelectFirst("//local/courseInfo/semester", doc)
+    const department = safeSelectFirst("//local/department", doc)
+    const mods = safeSelectFirst("//mods", doc)
+
+    if (semester) {
+        const temporal = createElement(doc, 'temporal')
+        temporal.textContent = semester.textContent
+        let subjectParent = safeSelectFirst("//mods/subject", doc)
+        if (!subjectParent) {
+            subjectParent = createElement(doc, 'subject')
+            mods.appendChild(subjectParent)
+        }
+        subjectParent.appendChild(temporal)
+    }
+
+    if (department) {
+        // TODO we could have a better map of department names to subject terms with URIs
+        // TODO terms like "Individualized" are not informative
+        const topic = createElement(doc, 'topic')
+        // Strip degree postfixes like " (BFA)" or " (MFA)"
+        topic.textContent = department.textContent.trim().replace(/\s+\([A-Z]+\)$/, '')
+        let subjectParent = safeSelectFirst("//mods/subject", doc)
+        if (!subjectParent) {
+            subjectParent = createElement(doc, 'subject')
+            mods.appendChild(subjectParent)
+        }
+        subjectParent.appendChild(topic)
+    }
+
+    return doc
+}
+
 /**
  * local/courseInfo/courseNumer & course -> mods/titleInfo/title
  * local/courseInfo/semester -> mods/part/partNumber
@@ -53,8 +101,10 @@ export function fixSyllabusTitle(doc) {
         titleInfo.appendChild(title)
 
         // Add partNumber for semester
-        if (hasDirectTextContent(semester)) {
-            moveAndRenameElement(doc, "//local/courseInfo/semester", '//mods/titleInfo', 'partNumber')
+        if (semester) {
+            const partNumber = createElement(doc, 'partNumber')
+            partNumber.textContent = semester.textContent
+            titleInfo.appendChild(partNumber)
         }
     }
 
@@ -113,6 +163,9 @@ export function convertSyllabusXMLtoMODS(xmlString) {
     // Add syllabi genre
     addGenre(doc)
 
+    // Add subjects
+    addSubjects(doc)
+
     // Remove empty elements last, after all transformations are complete
     removeEmptyElements(doc)
 

collection-export/syllabus.test.js

@@ -6,11 +6,31 @@ import {convertSyllabusXMLtoMODS} from './syllabus.js'
 // helper function to wrap XML in a root </xml> element
 const x = (xml) => `<xml>${xml}</xml>`
 
+describe('addSubjects', () => {
+    it('should add a temporal subject for semester', async () => {
+        const semester = 'Fall 2026'
+        const inputXML = x(`<local><courseInfo><semester>${semester}</semester></courseInfo></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const temporal = xpath.select1('//mods/subject/temporal', result)
+        assert.ok(temporal)
+        assert.strictEqual(temporal.textContent, semester)
+    })
+
+    it('should add a topic subject for department', async () => {
+        const department = 'Art Education (BFA)'
+        const inputXML = x(`<local><department>${department}</department></local>`)
+        const result = convertSyllabusXMLtoMODS(inputXML)
+        const topic = xpath.select1('//mods/subject/topic', result)
+        assert.ok(topic)
+        assert.strictEqual(topic.textContent, 'Art Education')
+    })
+})
+
 describe('addGenre', () => {
-    it('should add genre element with type=syllabus', async () => {
+    it('should add syllabi genre element with authority=aat', async () => {
         const inputXML = x(`<mods></mods>`)
         const result = convertSyllabusXMLtoMODS(inputXML)
-        const genre = xpath.select1('//mods/genre[@type="aat"]', result)
+        const genre = xpath.select1('//mods/genre[@authority="aat"]', result)
         assert.ok(genre)
         assert.strictEqual(genre.textContent, 'syllabi')
     })