-
Notifications
You must be signed in to change notification settings - Fork 64
Account for nested imgpkg bundles in the caching logic #399
Copy link
Copy link
Open
Labels
carvel-acceptedThis issue should be considered for future work and that the triage process has been completedThis issue should be considered for future work and that the triage process has been completedenhancementThis issue is a feature requestThis issue is a feature requestpriority/important-soonMust be staffed and worked on currently or soon.Must be staffed and worked on currently or soon.
Metadata
Metadata
Assignees
Labels
carvel-acceptedThis issue should be considered for future work and that the triage process has been completedThis issue should be considered for future work and that the triage process has been completedenhancementThis issue is a feature requestThis issue is a feature requestpriority/important-soonMust be staffed and worked on currently or soon.Must be staffed and worked on currently or soon.
Type
Projects
Status
No status
Describe the problem/challenge you have
imgpkgbundles might contain references to other imgpkg bundles (as in the case ofPackageRepositorybundles). Purely SHA based caching might lead to nested content being pulled from an older registry when a migration is attempted.Relevant bug in kapp-controller: carvel-dev/kapp-controller#1603
Describe the solution you'd like
Instead of accounting for just the SHA as a key while caching content, the entire registry URL should be considered.
Anything else you would like to add:
This would not be an issue in a kapp-controller upgrade scenario as an update would roll out new pods, dropping the old cache.
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.