Commit eb9e40c
committed
Add version annotation to APIService to prevent race conditions during rolling upgrades
During kapp-controller rolling upgrades via `kapp deploy`, a race condition can occur
where kapp reports success even though the APIService webhook is not ready yet. This
happens because kapp doesn't detect any changes in the APIService resource and
considers the deployment complete before the new APIService is fully operational.
This change adds a version annotation to the APIService that gets updated with each
release, ensuring kapp detects changes and properly waits for the APIService to be
ready during rolling upgrades.
Changes:
- Add kapp-controller.carvel.dev/version annotation to APIService metadata
- Update build script to replace version placeholder with actual release version
- Follow same pattern as existing Deployment resource versioning
Fixes race condition during kapp-controller upgrades where APIService readiness
is not properly validated.
Made-with: Cursor
Signed-off-by: Marin Dzhigarov <m.dzhigarov@gmail.com>
Made-with: Cursor1 parent 32fc399 commit eb9e40c
2 files changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
0 commit comments