fix: machine behavior in cases of input reject or exception

Author: vfusco

Makefile

@@ -196,17 +196,39 @@ integration-test: ## Execute e2e tests
 	@echo "Running end-to-end tests"
 	@go test -count=1 ./test --tags=endtoendtests
 
-echo-dapp: applications/echo-dapp ## Echo the dapp
+echo-dapp: applications/echo-dapp ## Echo dapp
+
+reject-dapp: applications/reject-dapp ## Reject dapp
+
+exception-dapp: applications/exception-dapp ## Exception dapp
 
 applications/echo-dapp: ## Create echo-dapp test application
 	@echo "Creating echo-dapp test application"
 	@mkdir -p applications
 	@cartesi-machine --ram-length=128Mi --store=applications/echo-dapp --final-hash -- ioctl-echo-loop --vouchers=1 --delegate-call-vouchers=1 --notices=1 --reports=1 --verbose=1
 
+applications/reject-dapp: ## Create reject-dapp test application
+	@echo "Creating reject-dapp test application"
+	@mkdir -p applications
+	@cartesi-machine --ram-length=128Mi --store=applications/reject-dapp --final-hash -- "rollup accept && rollup reject"
+
+applications/exception-dapp: ## Create exception-dapp test application
+	@echo "Creating exception-dapp test application"
+	@mkdir -p applications
+	@cartesi-machine --ram-length=128Mi --store=applications/exception-dapp --final-hash -- "rollup accept && echo '{\"payload\": \"0x7468697320697320612064756d6d7920657863657074696f6e2074657874\"}' | rollup exception"
+
 deploy-echo-dapp: applications/echo-dapp ## Deploy echo-dapp test application
 	@echo "Deploying echo-dapp test application"
 	@./cartesi-rollups-cli deploy application echo-dapp applications/echo-dapp/
 
+deploy-reject-dapp: applications/reject-dapp ## Deploy reject-dapp test application
+	@echo "Deploying reject-dapp test application"
+	@./cartesi-rollups-cli deploy application reject-dapp applications/reject-dapp/
+
+deploy-exception-dapp: applications/exception-dapp ## Deploy exception-dapp test application
+	@echo "Deploying exception-dapp test application"
+	@./cartesi-rollups-cli deploy application exception-dapp applications/exception-dapp/
+
 # Temporary test dependencies target while we are not using distribution packages
 DOWNLOADS_DIR = test/downloads
 CARTESI_TEST_MACHINE_IMAGES = $(DOWNLOADS_DIR)/linux.bin

internal/advancer/advancer.go

@@ -236,6 +236,15 @@ func (s *Service) processInputs(ctx context.Context, app *Application, inputs []
 			return err
 		}
 
+		s.Logger.Info("Processing input finished",
+			"application", app.Name,
+			"epoch", input.EpochIndex,
+			"index", input.Index,
+			"status", result.Status,
+			"outputs", len(result.Outputs),
+			"reports", len(result.Reports),
+		)
+
 		// Store the result in the database
 		err = s.repository.StoreAdvanceResult(ctx, input.EpochApplicationID, result)
 		if err != nil {

pkg/machine/implementation.go

@@ -128,19 +128,21 @@ func (m *machineImpl) OutputsHash(ctx context.Context) (Hash, error) {
 
 // Advance sends an input to the machine and processes it
 func (m *machineImpl) Advance(ctx context.Context, input []byte) (bool, []Output, []Report, Hash, error) {
+	outputsHash := Hash{}
+
 	// TODO: return the exception reason
 	accepted, outputs, reports, data, err := m.process(ctx, input, AdvanceStateRequest)
 	if err != nil {
-		return accepted, outputs, reports, Hash{}, err
+		return accepted, outputs, reports, outputsHash, err
 	}
 
-	if length := len(data); length != HashSize {
-		err = fmt.Errorf("%w (it has %d bytes)", ErrHashLength, length)
-		return accepted, outputs, reports, Hash{}, err
+	if accepted {
+		if length := len(data); length != HashSize {
+			err = fmt.Errorf("%w (it has %d bytes)", ErrHashLength, length)
+			return accepted, outputs, reports, outputsHash, err
+		}
+		copy(outputsHash[:], data)
 	}
-
-	var outputsHash Hash
-	copy(outputsHash[:], data)
 	return accepted, outputs, reports, outputsHash, nil
 }
 

pkg/machine/implementation_test.go

@@ -266,7 +266,7 @@ func (s *ImplementationSuite) TestAdvance() {
 	require.False(accepted)
 	require.Empty(outputs)
 	require.Empty(reports)
-	require.NotEqual(Hash{}, hash)
+	require.Equal(Hash{}, hash)
 	mockBackend2.AssertExpectations(s.T())
 
 	// Test advance with exception
@@ -286,6 +286,7 @@ func (s *ImplementationSuite) TestAdvance() {
 	accepted, outputs, reports, hash, err = machine3.Advance(ctx, input)
 	require.ErrorIs(err, ErrException)
 	require.False(accepted)
+	require.Equal(Hash{}, hash)
 	mockBackend3.AssertExpectations(s.T())
 
 	// Test advance with payload too large