refactor(services): use factory instead initializer to create supervisor

Author: renatomaia

cmd/cartesi-rollups-advancer/root/root.go

@@ -110,9 +110,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.AdvancerTelemetryAddress,
 		Services:             services,
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

cmd/cartesi-rollups-claimer/root/root.go

@@ -122,9 +122,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.ClaimerTelemetryAddress,
 		Services:             []service.SupervisedService{claimerService},
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

cmd/cartesi-rollups-evm-reader/root/root.go

@@ -123,9 +123,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.EvmReaderTelemetryAddress,
 		Services:             []service.SupervisedService{readerService},
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

cmd/cartesi-rollups-jsonrpc-api/root/root.go

@@ -95,9 +95,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.JsonrpcTelemetryAddress,
 		Services:             []service.SupervisedService{jsonrpcService},
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

cmd/cartesi-rollups-node/root/root.go

@@ -187,5 +187,7 @@ func run(cmd *cobra.Command, args []string) {
 	nodeService, err := node.Create(ctx, &createInfo)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, nodeService.Serve())
 }

cmd/cartesi-rollups-prt/root/root.go

@@ -111,9 +111,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.PrtTelemetryAddress,
 		Services:             []service.SupervisedService{prtService},
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

cmd/cartesi-rollups-validator/root/root.go

@@ -97,9 +97,10 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.ValidatorTelemetryAddress,
 		Services:             []service.SupervisedService{validatorService},
 	}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	supervisor, err := service.NewSupervisor(supCfg)
 	cli.CheckErr(logger, err)
 
+	logger.Info("Starting service", "config", cfg)
+
 	cli.CheckErr(logger, supervisor.Serve())
 }

internal/advancer/advancer_test.go

@@ -57,9 +57,9 @@ func newMockAdvancerServiceWithBatchSize(
 	if err != nil {
 		return nil, err
 	}
-	supCfg := &service.SupervisorConfigs{Services: []service.SupervisedService{s}}
-	supervisor := &service.Supervisor{}
-	err = service.InitServicesSupervisor(supCfg, supervisor)
+	_, err = service.NewSupervisor(&service.SupervisorConfigs{
+		Services: []service.SupervisedService{s},
+	})
 	if err != nil {
 		return nil, err
 	}

internal/advancer/service.go

@@ -104,8 +104,6 @@ func Create(ctx context.Context, c *CreateInfo) ([]service.SupervisedService, er
 
 	s.snapshotsDir = c.Config.SnapshotsDir
 
-	service.LogConfig(s.Logger, c.Config)
-
 	return services, nil
 }
 

internal/claimer/service.go

@@ -146,8 +146,6 @@ func Create(ctx context.Context, c *CreateInfo) (service.SupervisedService, erro
 		defaultBlock:  nodeConfig.DefaultBlock,
 	}
 
-	service.LogConfig(s.Logger, c.Config)
-
 	return s, nil
 }