refactor(services): move service initialization to the Supervisor construction

This separation was made so that a initialization context (usually with a
'MaxStartupTime' timeout) is used to bound the service initialization, and leave
'Serve' method without a context argument so it is clear that 'Serve' is not
controlled by a context object.

Author: renatomaia

cmd/cartesi-rollups-advancer/root/root.go

@@ -131,7 +131,8 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.AdvancerTelemetryAddress,
 		Factories:            factories,
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-claimer/root/root.go

@@ -101,7 +101,8 @@ func run(cmd *cobra.Command, args []string) {
 			},
 		},
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-evm-reader/root/root.go

@@ -101,7 +101,8 @@ func run(cmd *cobra.Command, args []string) {
 			},
 		},
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-jsonrpc-api/root/root.go

@@ -89,7 +89,8 @@ func run(cmd *cobra.Command, args []string) {
 			},
 		},
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-node/root/root.go

@@ -228,7 +228,8 @@ func run(cmd *cobra.Command, args []string) {
 		TelemetryAddress:     cfg.NodeTelemetryAddress,
 		Factories:            factories,
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-prt/root/root.go

@@ -89,7 +89,8 @@ func run(cmd *cobra.Command, args []string) {
 			},
 		},
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

cmd/cartesi-rollups-validator/root/root.go

@@ -89,7 +89,8 @@ func run(cmd *cobra.Command, args []string) {
 			},
 		},
 	}
-	sup := service.NewSupervisor(supCfg)
+	sup, err := service.NewSupervisor(ctx, supCfg)
+	cli.CheckErr(logger, err)
 	defer sup.Close()
-	cli.CheckErr(logger, sup.Serve(ctx))
+	cli.CheckErr(logger, sup.Serve())
 }

internal/advancer/advancer_test.go

@@ -46,13 +46,14 @@ func newMockAdvancerServiceWithBatchSize(
 	repo *MockRepository,
 	batchSize uint64,
 ) (*Service, error) {
+	sup, err := service.NewSupervisor(context.Background(), &service.SupervisorConfigs{})
 	s := &Service{
 		inputBatchSize: batchSize,
 		machineManager: machineManager,
 		repository:     repo,
-		supervisor:     service.NewSupervisor(&service.SupervisorConfigs{}),
+		supervisor:     sup,
 	}
-	err := service.InitTickServiceTemplate(&s.TickServiceTemplate, &service.TickServiceConfigs{}, s)
+	err = service.InitTickServiceTemplate(&s.TickServiceTemplate, &service.TickServiceConfigs{}, s)
 	if err != nil {
 		return nil, err
 	}

internal/evmreader/edge_cases_test.go

@@ -515,7 +515,7 @@ func (s *EvmReaderSuite) TestAdapterCacheInvalidationOnConfigChange() {
 
 	done := make(chan struct{})
 	go func() {
-		err := s.supervisor.Serve(s.ctx)
+		err := s.supervisor.Serve()
 		s.Require().NoError(err)
 		close(done)
 	}()

internal/evmreader/evmreader_test.go

@@ -81,8 +81,9 @@ func (s *EvmReaderSuite) SetupTest() {
 			},
 		},
 	}
-	s.supervisor = service.NewSupervisor(&supCfg)
+	sup, err := service.NewSupervisor(s.ctx, &supCfg)
 	s.Require().NoError(err)
+	s.supervisor = sup
 }
 
 func (s *EvmReaderSuite) TearDownTest() {
@@ -313,7 +314,7 @@ func (s *EvmReaderSuite) TestItRunsWhenConnectionFails() {
 
 	done := make(chan struct{})
 	go func() {
-		err := s.supervisor.Serve(s.T().Context())
+		err := s.supervisor.Serve()
 		s.Require().NoError(err)
 		close(done)
 	}()
@@ -334,7 +335,7 @@ func (s *EvmReaderSuite) TestRunResetsRetriesAfterProcessingHeaders() {
 
 	done := make(chan struct{})
 	go func() {
-		err := s.supervisor.Serve(s.T().Context())
+		err := s.supervisor.Serve()
 		s.Require().NoError(err)
 		close(done)
 	}()