🐛 Update gvdi, fix validation sync error

karnkaul · karnkaul · commit eaed9d9ec5e5 · 2025-05-11T14:28:03.000-07:00
- Fix flags in presets
- Enable workflow_dispatch
- Update capo to v2.0.1
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,6 +1,5 @@
 name: ci-pr
-on:
-  pull_request
+on: [pull_request, workflow_dispatch]
 jobs:
   x64-linux-gcc:
     runs-on: ubuntu-latest
diff --git a/CMakePresets.json b/CMakePresets.json
@@ -50,8 +50,9 @@
       "inherits": "base-gcc",
       "binaryDir": "${sourceDir}/out/gcc",
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS_DEBUG_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",
-        "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror"
+        "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",
+        "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "-Werror",
+        "CMAKE_CXX_FLAGS_RELEASE_INIT": "-Werror"
       }
     },
     {
@@ -61,8 +62,9 @@
       "inherits": "base-clang",
       "binaryDir": "${sourceDir}/out/clang",
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS_DEBUG_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",
-        "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror"
+        "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",
+        "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "-Werror",
+        "CMAKE_CXX_FLAGS_RELEASE_INIT": "-Werror"
       }
     },
     {
@@ -72,7 +74,8 @@
       "inherits": "base-msvc",
       "binaryDir": "${sourceDir}/out/msvc",
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS_INIT": "/WX"
+        "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "/WX",
+        "CMAKE_CXX_FLAGS_RELEASE_INIT": "/WX"
       }
     },
     {
@@ -82,8 +85,7 @@
       "inherits": "default",
       "binaryDir": "${sourceDir}/out/ubsan",
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS_DEBUG_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror=return-type",
-        "CMAKE_CXX_FLAGS_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror"
+        "CMAKE_CXX_FLAGS_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror=return-type"
       }
     },
     {
@@ -93,8 +95,7 @@
       "inherits": "default",
       "binaryDir": "${sourceDir}/out/asan",
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS_DEBUG_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror=return-type",
-        "CMAKE_CXX_FLAGS_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror"
+        "CMAKE_CXX_FLAGS_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror=return-type"
       }
     },
     {
diff --git a/ext/src.zip b/ext/src.zip
diff --git a/src/app.cpp b/src/app.cpp
@@ -4,6 +4,7 @@
 #include <embedded.hpp>
 #include <klib/version_str.hpp>
 #include <log.hpp>
+#include <utility>
 
 namespace riff {
 namespace {
diff --git a/src/ini.cpp b/src/ini.cpp
@@ -3,6 +3,7 @@
 #include <cassert>
 #include <format>
 #include <fstream>
+#include <vector>
 
 namespace riff {
 namespace {
diff --git a/src/ini.hpp b/src/ini.hpp
@@ -4,7 +4,6 @@
 #include <charconv>
 #include <string>
 #include <unordered_map>
-#include <vector>
 
 namespace riff {
 class Ini {

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,9 @@`
`50`	`50`	`"inherits": "base-gcc",`
`51`	`51`	`"binaryDir": "${sourceDir}/out/gcc",`
`52`	`52`	`"cacheVariables": {`
`53`		`- "CMAKE_CXX_FLAGS_DEBUG_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",`
`54`		`- "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror"`
	`53`	`+ "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",`
	`54`	`+ "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "-Werror",`
	`55`	`+ "CMAKE_CXX_FLAGS_RELEASE_INIT": "-Werror"`
`55`	`56`	`}`
`56`	`57`	`},`
`57`	`58`	`{`
`@@ -61,8 +62,9 @@`
`61`	`62`	`"inherits": "base-clang",`
`62`	`63`	`"binaryDir": "${sourceDir}/out/clang",`
`63`	`64`	`"cacheVariables": {`
`64`		`- "CMAKE_CXX_FLAGS_DEBUG_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",`
`65`		`- "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror"`
	`65`	`+ "CMAKE_CXX_FLAGS_INIT": "-Wall -Wextra -Wpedantic -Werror=return-type",`
	`66`	`+ "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "-Werror",`
	`67`	`+ "CMAKE_CXX_FLAGS_RELEASE_INIT": "-Werror"`
`66`	`68`	`}`
`67`	`69`	`},`
`68`	`70`	`{`
`@@ -72,7 +74,8 @@`
`72`	`74`	`"inherits": "base-msvc",`
`73`	`75`	`"binaryDir": "${sourceDir}/out/msvc",`
`74`	`76`	`"cacheVariables": {`
`75`		`- "CMAKE_CXX_FLAGS_INIT": "/WX"`
	`77`	`+ "CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT": "/WX",`
	`78`	`+ "CMAKE_CXX_FLAGS_RELEASE_INIT": "/WX"`
`76`	`79`	`}`
`77`	`80`	`},`
`78`	`81`	`{`
`@@ -82,8 +85,7 @@`
`82`	`85`	`"inherits": "default",`
`83`	`86`	`"binaryDir": "${sourceDir}/out/ubsan",`
`84`	`87`	`"cacheVariables": {`
`85`		`- "CMAKE_CXX_FLAGS_DEBUG_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror=return-type",`
`86`		`- "CMAKE_CXX_FLAGS_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror"`
	`88`	`+ "CMAKE_CXX_FLAGS_INIT": "-fsanitize=undefined -Wall -Wextra -Wpedantic -Werror=return-type"`
`87`	`89`	`}`
`88`	`90`	`},`
`89`	`91`	`{`
`@@ -93,8 +95,7 @@`
`93`	`95`	`"inherits": "default",`
`94`	`96`	`"binaryDir": "${sourceDir}/out/asan",`
`95`	`97`	`"cacheVariables": {`
`96`		`- "CMAKE_CXX_FLAGS_DEBUG_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror=return-type",`
`97`		`- "CMAKE_CXX_FLAGS_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror"`
	`98`	`+ "CMAKE_CXX_FLAGS_INIT": "-fsanitize=address -Wall -Wextra -Wpedantic -Werror=return-type"`
`98`	`99`	`}`
`99`	`100`	`},`
`100`	`101`	`{`