Make add/remove package commands idempotent #6577
Closed
armadi1809 wants to merge 1 commit intocaddyserver:masterfrom
Closed
Make add/remove package commands idempotent #6577armadi1809 wants to merge 1 commit intocaddyserver:masterfrom
armadi1809 wants to merge 1 commit intocaddyserver:masterfrom
Conversation
shivam-baghla
approved these changes
Sep 25, 2024
Member
|
Hmm, this means it'll try to fetch the build and replace it even if it doesn't make sense to do so. I think the idea is that it would just do nothing if it's already good, but not throw an error. |
Member
|
I agree. How would you feel about changing this patch to not perform the task if the build is not different? |
Phamousomaka
approved these changes
Jan 5, 2025
Member
|
I'll close this as inactive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6548