filesystem changes

[elee1766]

No description provided.

[elee1766]

@mohammed90 can you try this?

when i run caddyfile adapt, i get

{
"apps": {
filesystems: {filesystems: [{"name":"foo","files_system":{...}}
//...

not sure if this is right still.

[elee1766]

note for myself: notify these projects

https://github.com/sagikazarmark/caddy-fs-s3
https://github.com/tecosaur/caddy-fs-git

[mohammed90]

@mohammed90 can you try this?

This works! See mohammed90/caddy-git-fs#2. I had to introduce a local interface to reach the Unwrap method, and this is alright.

when i run caddyfile adapt, i get

{
"apps": {
filesystems: {filesystems: [{"name":"foo","files_system":{...}}
//...

not sure if this is right still.

I wonder if it's possible to reduce the nesting. In other words, to make it:

{
    "apps": {
        filesystems: {
            "foo": {
                    // filesystem stuff...
                    "backend": "fs_backend_module" ...
            },
            "bar": {
                    // filesystem stuff...
                    "backend": "fs_backend_module" ...
            }
        }

or if necessary at all 🤔

[mholt]

Nit, but should it be file_systems? (Since it's two words)

[elee1766]

Nit, but should it be file_systems? (Since it's two words)

https://caddyserver.com/docs/caddyfile/options#storage

dont think it's a nit, i think you're right, you already use file_system elsewhere in the project. will change soon

[mholt]

Suggested change

	FileSystemRaw json.RawMessage `json:"filesystem,omitempty" caddy:"namespace=caddy.fs inline_key=backend"`
	FileSystemRaw json.RawMessage `json:"file_system,omitempty" caddy:"namespace=caddy.fs inline_key=backend"`

[francislavoie]

huh? The point of this PR is to fix that, but you're suggesting reverting the fix back to status-quo. I'm confused.

[mholt]

Hmm, well I thought we agreed it was two words: #6466 (comment) (see also next comment)

[elee1766]

i changed this in other places (see httptype.go), but i did not change it here in fear of breaking existing caddyfiles.

[francislavoie]

I'm not really sure what was going on in this PR, but without a clear title and PR description and no activity in 1.5 years, I'll close it as inactive.