Skip to content

Commit 8fe0eee

Browse files
authored
Ignore p2_udp_send_to_closed_receiver on macOS (#14031)
This [failed on CI recently][log] and it was already flaky on Windows. Maybe eventually we'll just remove this test for flakiness, but for now I'd like to keep flaky tests out of the critical path of the merge queue. [log]: https://github.com/bytecodealliance/wasmtime/actions/runs/30563046634/job/90940763865
1 parent 39fd51e commit 8fe0eee

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

crates/wasi/tests/all/p2/async_.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,9 @@ async fn p2_udp_connect() {
372372
run(P2_UDP_CONNECT_COMPONENT, |_| {}).await.unwrap()
373373
}
374374
#[test_log::test(tokio::test(flavor = "multi_thread"))]
375+
// See the comment on the `p2::sync` variation of this test; for why this is
376+
// ignored on macos
377+
#[cfg_attr(target_os = "macos", ignore)]
375378
async fn p2_udp_send_to_closed_receiver() {
376379
run(P2_UDP_SEND_TO_CLOSED_RECEIVER_COMPONENT, |_| {})
377380
.await

crates/wasi/tests/all/p2/sync.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,11 @@ fn p2_udp_connect() {
350350
// consistently fails when run in combination with the `p2::async_` variation,
351351
// and we've thus far been unable to determine the reason.
352352
#[cfg_attr(windows, ignore = "This test is flaky on Windows.")]
353+
// This test is flaky on macOS in CI. One possible reason is that this relies on
354+
// a port being closed which concurrent tests can otherwise re-bind. Another
355+
// reason is that maybe this is just flaky on macOS (LLMs say something about
356+
// the OS rate-limiting ICMP messages if they're to be believed).
357+
#[cfg_attr(target_os = "macos", ignore = "This test is flaky on macOS.")]
353358
fn p2_udp_send_to_closed_receiver() {
354359
run(P2_UDP_SEND_TO_CLOSED_RECEIVER_COMPONENT, |_| {}).unwrap()
355360
}

0 commit comments

Comments
 (0)