fix(bcode-laminar): address cubic review

- processor.ts: spawningSpanIdToToolUseId is keyed by UUID
  (otelSpanIdToUUID(spanId)) at insert time but onEnd was deleting by
  raw hex span id, so entries were never cleaned up. Use the UUID for
  delete to match.
- plugin.ts: server.instance.disposed now ends any open turn spans,
  clears the subagent map, and shuts down the NodeSDK (which drains
  the BatchSpanProcessor and unregisters the global TracerProvider).
- plugin.ts: LMNR_GRPC_PORT is validated (positive integer in
  1..65535) before use, with fallback to the appropriate default
  (8443 for api.lmnr.ai, 443 elsewhere). Garbage values no longer
  produce NaN endpoint URLs.

Author: bcode

packages/bcode-laminar/src/plugin.ts

@@ -18,14 +18,22 @@ import { OpenCodeLaminarSpanProcessor } from "./processor"
 import { startTurnSpan } from "./span"
 import { sessionCurrentTurnSpan, subagentSessionIds } from "./state"
 
+const DEFAULT_GRPC_PORT_LMNR = 8443
+const DEFAULT_GRPC_PORT_GENERIC = 443
+
+const parsePort = (raw: string | undefined, fallback: number): number => {
+  if (!raw) return fallback
+  const n = Number(raw)
+  return Number.isInteger(n) && n > 0 && n <= 65535 ? n : fallback
+}
+
 export const LaminarPlugin: Plugin = ({ client }) => {
   const projectApiKey = process.env.LMNR_PROJECT_API_KEY
   const baseUrl = process.env.LMNR_BASE_URL ?? "https://api.lmnr.ai"
-  const port = process.env.LMNR_GRPC_PORT
-    ? Number(process.env.LMNR_GRPC_PORT)
-    : baseUrl === "https://api.lmnr.ai"
-      ? 8443
-      : 443
+  const port = parsePort(
+    process.env.LMNR_GRPC_PORT,
+    baseUrl === "https://api.lmnr.ai" ? DEFAULT_GRPC_PORT_LMNR : DEFAULT_GRPC_PORT_GENERIC,
+  )
 
   const log = (level: "debug" | "info" | "warn" | "error", message: string) => {
     client.app
@@ -64,9 +72,19 @@ export const LaminarPlugin: Plugin = ({ client }) => {
           await processor.forceFlush()
           break
         }
-        case "server.instance.disposed":
-          await processor.shutdown()
+        case "server.instance.disposed": {
+          // End any turn spans still open so they're flushed before shutdown.
+          for (const [sessionId, span] of Object.entries(sessionCurrentTurnSpan)) {
+            span.end()
+            delete sessionCurrentTurnSpan[sessionId]
+          }
+          for (const key of Object.keys(subagentSessionIds)) delete subagentSessionIds[key]
+          // sdk.shutdown() drains the inner BatchSpanProcessor and exporter
+          // and removes the global TracerProvider; explicit processor.shutdown()
+          // is redundant but harmless.
+          await sdk.shutdown().catch(() => {})
           break
+        }
         case "session.created":
         case "session.updated":
           if (event.properties.info.parentID) {

packages/bcode-laminar/src/processor.ts

@@ -165,7 +165,9 @@ export class OpenCodeLaminarSpanProcessor implements SpanProcessor {
     const spanId = span.spanContext().spanId
     this.spanIdLists.delete(spanId)
     this.spanIdToPath.delete(spanId)
-    delete this.spawningSpanIdToToolUseId[spanId]
+    // spawningSpanIdToToolUseId is keyed by UUID (matches `lmnr.span.ids_path`
+    // entries that the descendant scan iterates), not by the raw hex span id.
+    delete this.spawningSpanIdToToolUseId[otelSpanIdToUUID(spanId)]
     makeSpanOtelV2Compatible(span)
     this.inner.onEnd(span)
   }