feat(staged): add resilient web resume cache - #734
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b817705aa3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export function getSessionMessages(sessionId: string): Promise<SwrResult<SessionMessage[]>> { | ||
| return cachedCommand('get_session_messages', { sessionId }, { ttl: 5 * 60_000 }); |
There was a problem hiding this comment.
In web/PWA mode this caches get_session_messages for five minutes, including empty or partial results while a session is still running. SessionModal.poll() calls getSessionMessages(sessionId) whenever messages.length === 0 and ignores revalidating; if the first poll caches [] before the agent emits output, every subsequent poll hits this fresh cache and never reaches the backend until the TTL expires, so live session output can appear frozen for up to five minutes. Running sessions should bypass this cache or use a much shorter/stale-only policy.
Useful? React with 👍 / 👎.
| export function listBranchesForProject(projectId: string): Promise<SwrResult<Branch[]>> { | ||
| return cachedCommand('list_branches_for_project', { projectId }, { ttl: 2 * 60_000 }); |
There was a problem hiding this comment.
This introduces a two-minute fresh cache for branch lists, but branch-mutating commands such as renameBranch still update only local UI state and do not invalidate list_branches_for_project. After renaming a branch, any remount/navigation or cache-stale refresh that calls listBranchesForProject(projectId) within the TTL can reuse the old cached branch list and restore stale branch data until the cache expires. Please either invalidate this cache in all branch mutators or avoid fresh short-circuiting for branch lists.
Useful? React with 👍 / 👎.
b817705 to
d84b179
Compare
d84b179 to
e5ee831
Compare
e5ee831 to
0765166
Compare
Add a stale-while-revalidate cache for command results and route the staged web UI through cached fetch helpers. Register page lifecycle and cache invalidation listeners so the iOS web app resumes quickly while refreshing stale state in the background. Force provider refreshes to revalidate rather than serving cached state. Signed-off-by: Matt Toohey <contact@matttoohey.com>
0765166 to
6606433
Compare
matt2e
changed the title
1 participant
Summary