Migrate app to navigation 3 library

[thunderbiscuit]

Docs here. There are a few good videos on YouTube as well.

[anuj990]

@thunderbiscuit Hi , seeing that this issue has been inactive since August, I would like to step in and handle the migration. I have experience implementing Type Safe Navigation and can refactor the existing routes into a graph to improve compile time safety. If this migration is still desired, please assign it to me and I will start the refactor immediately.

[thunderbiscuit]

Sounds great @anuj990! Feel free to start working on this. You can see how we do it in Padawan Wallet if that helps.

Notice that in this wallet, you're likely to run into a bit of an architecture issue with the navigation drawer and the fact that we basically have a navigation graph inside another navigation graph, which if I recall correctly the new Nav3 library doesn't handle too well (but things might have evolved too, or we might be able to clean up the navigation architecture in a way to clean this up and make it simpler).

Feel free to propose changes or ask questions here or on your draft PR if you open one, and we can hash out the best way forward. Thanks for working on this!

[thunderbiscuit]

@anuj990 can you pause work on this for a little bit? The navigation has been a pain in our side for a little while and I don't want your contribution to not be usable, and I think we need a big cleanup of the navigation on the app first before the migration.

Let me see if I can implement a cleaner nav first (I'm thinking of removing the navigation drawer altogether), and then the migration to nav3 will be much easier. Or have you done the work already? If so feel free to open a PR even if it's just a draft, so I can provide direction on it.

[anuj990]

@thunderbiscuit
Thanks for the clarification,
I haven't made any important progress in this just added new dependencies,
If you want I can help too
Please let me know

[thunderbiscuit]

All good, this is ready to go for the migration if you're still interested. I pushed 2 new commits which flatten the whole navigation into one single NavHost. Easier to migrate to nav3 now.

[anuj990]

@thunderbiscuit
Hey, I have completed most of the migration, but my exams start next week, so I will raise a PR once I am free from them