Commit d0eaadf
committed
Merge #2099: Fix no-std compilation
546b07e chore(example_cli,esplora): Fix no-std compilation (志宇)
Pull request description:
### Description
`serde_json` requires either `std` or `alloc` feature enabled. We just enable `alloc` as we don't need the features that `std` provides.
### Notes to the reviewers
`alloc` is just a subset of `std`. `json_serde` has `from_reader()` & `to_writer()` methods if `std` is enabled. We aren't using those methods so just having `alloc` is fine.
I'm also not sure why an explicit `alloc` cargo feature flag is needed in `serde_json`. They can just have an internal prelude based on whether the `std` feature is enabled.
### Checklists
#### All Submissions:
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
ACKs for top commit:
luisschwab:
ACK 546b07e
oleonardolima:
ACK 546b07e
Tree-SHA512: 05afc4d7ee3c1c7de8f2cd497a6a02f7bc4f1410e83604627c8af2b1a36fb92cd2fbe774a8d63bf2c4cffc8d4ddcc009adfdaeb59cdca3201f128f34639f39c22 files changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
0 commit comments