chore: Remove gosec from test files

Author: alarso16

.gosec-golangci.yml

@@ -3,3 +3,13 @@ linters:
   default: none
   enable:
     - gosec
+  exclusions:
+    rules:
+      # Exclude some linters from running on test files.
+      # 1. Exclude the top level tests/ directory.
+      # 2. Exclude any file prefixed with test_ in any directory.
+      # 3. Exclude any directory suffixed with test.
+      # 4. Exclude any file suffixed with _test.go.
+      - path: "(^tests/)|(^(.*/)*test_[^/]*\\.go$)|(.*test/.*)|(.*_test\\.go$)"
+        linters:
+          - gosec

chains/atomic/atomictest/shared_memory.go

@@ -46,14 +46,14 @@ func TestSharedMemoryPutAndGet(t *testing.T, chainID0, chainID1 ids.ID, sm0, sm1
 // can support large values.
 func TestSharedMemoryLargePutGetAndRemove(t *testing.T, chainID0, chainID1 ids.ID, sm0, sm1 atomic.SharedMemory, _ database.Database) {
 	require := require.New(t)
-	rand := rand.New(rand.NewSource(0)) //#nosec G404
+	rand := rand.New(rand.NewSource(0))
 
 	totalSize := 16 * units.MiB  // 16 MiB
 	elementSize := 4 * units.KiB // 4 KiB
 	pairSize := 2 * elementSize  // 8 KiB
 
 	b := make([]byte, totalSize)
-	_, err := rand.Read(b) // #nosec G404
+	_, err := rand.Read(b)
 	require.NoError(err)
 
 	elems := []*atomic.Element{}
@@ -152,7 +152,7 @@ func TestSharedMemoryLargeIndexed(t *testing.T, chainID0, chainID1 ids.ID, sm0,
 	pairSize := 3 * elementSize  // 3 KiB
 
 	b := make([]byte, totalSize)
-	_, err := rand.Read(b) // #nosec G404
+	_, err := rand.Read(b)
 	require.NoError(err)
 
 	elems := []*atomic.Element{}
@@ -307,14 +307,14 @@ func TestPutAndRemoveBatch(t *testing.T, chainID0, _ ids.ID, _, sm1 atomic.Share
 // support large batches.
 func TestSharedMemoryLargeBatchSize(t *testing.T, _, chainID1 ids.ID, sm0, _ atomic.SharedMemory, db database.Database) {
 	require := require.New(t)
-	rand := rand.New(rand.NewSource(0)) //#nosec G404
+	rand := rand.New(rand.NewSource(0))
 
 	totalSize := 8 * units.MiB   // 8 MiB
 	elementSize := 4 * units.KiB // 4 KiB
 	pairSize := 2 * elementSize  // 8 KiB
 
 	bytes := make([]byte, totalSize)
-	_, err := rand.Read(bytes) // #nosec G404
+	_, err := rand.Read(bytes)
 	require.NoError(err)
 
 	batch := db.NewBatch()

database/dbtest/benchmark.go

@@ -46,9 +46,9 @@ func SetupBenchmark(b *testing.B, count int, keySize, valueSize int) ([][]byte,
 	for i := 0; i < count; i++ {
 		keyBytes := make([]byte, keySize)
 		valueBytes := make([]byte, valueSize)
-		_, err := rand.Read(keyBytes) // #nosec G404
+		_, err := rand.Read(keyBytes)
 		require.NoError(err)
-		_, err = rand.Read(valueBytes) // #nosec G404
+		_, err = rand.Read(valueBytes)
 		require.NoError(err)
 		keys[i], values[i] = keyBytes, valueBytes
 	}

database/dbtest/dbtest.go

@@ -1241,16 +1241,16 @@ func FuzzNewIteratorWithPrefix(f *testing.F, db database.Database) {
 		numKeyValues uint,
 	) {
 		require := require.New(t)
-		r := rand.New(rand.NewSource(randSeed)) // #nosec G404
+		r := rand.New(rand.NewSource(randSeed))
 
 		// Put a bunch of key-values
 		expected := map[string][]byte{}
 		for i := 0; i < int(numKeyValues); i++ {
 			key := make([]byte, r.Intn(maxKeyLen))
-			_, _ = r.Read(key) // #nosec G404
+			_, _ = r.Read(key)
 
 			value := make([]byte, r.Intn(maxValueLen))
-			_, _ = r.Read(value) // #nosec G404
+			_, _ = r.Read(value)
 
 			if len(value) == 0 {
 				// Consistently treat zero length values as nil
@@ -1305,17 +1305,17 @@ func FuzzNewIteratorWithStartAndPrefix(f *testing.F, db database.Database) {
 		numKeyValues uint,
 	) {
 		require := require.New(t)
-		r := rand.New(rand.NewSource(randSeed)) // #nosec G404
+		r := rand.New(rand.NewSource(randSeed))
 
 		expected := map[string][]byte{}
 
 		// Put a bunch of key-values
 		for i := 0; i < int(numKeyValues); i++ {
 			key := make([]byte, r.Intn(maxKeyLen))
-			_, _ = r.Read(key) // #nosec G404
+			_, _ = r.Read(key)
 
 			value := make([]byte, r.Intn(maxValueLen))
-			_, _ = r.Read(value) // #nosec G404
+			_, _ = r.Read(value)
 
 			if len(value) == 0 {
 				// Consistently treat zero length values as nil

ids/bits_test.go

@@ -70,7 +70,7 @@ func TestEqualSubsetBadMiddle(t *testing.T) {
 }
 
 func TestEqualSubsetAll3Bytes(t *testing.T) {
-	seed := rand.Uint64() //#nosec G404
+	seed := rand.Uint64()
 	t.Logf("seed: %d", seed)
 	id1 := ID{}.Prefix(seed)
 

tests/fixture/bootstrapmonitor/e2e/e2e_test.go

@@ -254,7 +254,7 @@ func buildImage(tc tests.TestContext, imageName string, forceNewHash bool, scrip
 		tc.ContextWithTimeout(e2e.DefaultTimeout*2), // Double the timeout to account for CI being really slow
 		"bash",
 		args...,
-	) // #nosec G204
+	)
 	cmd.Env = append(os.Environ(),
 		"DOCKER_IMAGE="+imageName,
 		"FORCE_TAG_MASTER=1",

tests/fixture/e2e/env.go

@@ -235,7 +235,7 @@ func NewTestEnvironment(tc tests.TestContext, flagVars *FlagVars, desiredNetwork
 func (te *TestEnvironment) GetRandomNodeURI() tmpnet.NodeURI {
 	var (
 		tc             = te.testContext
-		r              = rand.New(rand.NewSource(time.Now().Unix())) //#nosec G404
+		r              = rand.New(rand.NewSource(time.Now().Unix()))
 		network        = te.GetNetwork()
 		availableNodes = []*tmpnet.Node{}
 	)

tests/load/tests.go

@@ -74,8 +74,8 @@ func NewRandomTest(
 		// twice is practically zero. Using random values simplifies gas calculations
 		// as it removes the need to use an SLOAD operation to verify a different
 		// value is being written.
-		writeRand  = rand.New(rand.NewSource(0)) //#nosec G404
-		modifyRand = rand.New(rand.NewSource(1)) //#nosec G404
+		writeRand  = rand.New(rand.NewSource(0))
+		modifyRand = rand.New(rand.NewSource(1))
 	)
 
 	weightedTests := []WeightedTest{
@@ -190,7 +190,7 @@ func NewRandomWeightedTest(
 		)
 	}
 
-	rand := rand.New(source) //#nosec G404
+	rand := rand.New(source)
 
 	return &RandomWeightedTest{
 		tests:       tests,

utils/bag/bag_benchmark_test.go

@@ -9,7 +9,7 @@ import (
 )
 
 func BenchmarkBagListSmall(b *testing.B) {
-	rand := rand.New(rand.NewSource(1337)) //#nosec G404
+	rand := rand.New(rand.NewSource(1337))
 	smallLen := 5
 	bag := Bag[int]{}
 	for i := 0; i < smallLen; i++ {
@@ -22,7 +22,7 @@ func BenchmarkBagListSmall(b *testing.B) {
 }
 
 func BenchmarkBagListMedium(b *testing.B) {
-	rand := rand.New(rand.NewSource(1337)) //#nosec G404
+	rand := rand.New(rand.NewSource(1337))
 	mediumLen := 25
 	bag := Bag[int]{}
 	for i := 0; i < mediumLen; i++ {
@@ -36,7 +36,7 @@ func BenchmarkBagListMedium(b *testing.B) {
 }
 
 func BenchmarkBagListLarge(b *testing.B) {
-	rand := rand.New(rand.NewSource(1337)) //#nosec G404
+	rand := rand.New(rand.NewSource(1337))
 	largeLen := 100000
 	bag := Bag[int]{}
 	for i := 0; i < largeLen; i++ {

utils/bloom/filter_test.go

@@ -60,7 +60,7 @@ func TestNormalUsage(t *testing.T) {
 
 	toAdd := make([]uint64, 1024)
 	for i := range toAdd {
-		toAdd[i] = rand.Uint64() //#nosec G404
+		toAdd[i] = rand.Uint64()
 	}
 
 	initialNumHashes, initialNumBytes := OptimalParameters(1024, 0.01)