Merge pull request #4 from arikama/f/3

dont expose fields direct

Author: cglotr

README.md

@@ -28,7 +28,11 @@ import (
 
 func Test(t *testing.T) {
 	mySql, _ := mysqltestcontainer.Create("test")
-	mySql.Db.Ping()
+	db := mySql.GetDb()
+	err := db.Ping()
+	if err != nil {
+		log.L.Errorln(err.Error())
+	}
 }
 ```
 

mysqltestcontainer/create.go

@@ -46,12 +46,14 @@ func Create(databaseName string) (*MySql, error) {
 	}
 	kifu.Info("MySQL test container started successfully!")
 	mySql := &MySql{
-		Db:       db,
-		Username: rootUsername,
-		Password: rootPassword,
-		Ip:       host,
-		Port:     p,
-		DbName:   databaseName,
+		db: db,
+		dbInfo: &DbInfo{
+			Username: rootUsername,
+			Password: rootPassword,
+			Ip:       host,
+			Port:     p,
+			DbName:   databaseName,
+		},
 	}
 	return mySql, nil
 }

mysqltestcontainer/create_example_test.go

@@ -2,9 +2,14 @@ package mysqltestcontainer_test
 
 import (
 	"github.com/arikama/go-mysql-test-container/mysqltestcontainer"
+	"github.com/containerd/containerd/log"
 )
 
 func ExampleCreate() {
 	mySql, _ := mysqltestcontainer.Create("test")
-	mySql.Db.Ping()
+	db := mySql.GetDb()
+	err := db.Ping()
+	if err != nil {
+		log.L.Errorln(err.Error())
+	}
 }

mysqltestcontainer/create_test.go

@@ -11,14 +11,17 @@ func TestCreate(t *testing.T) {
 	mySql, err := mysqltestcontainer.Create("test")
 
 	assert.Nil(t, err)
-	assert.NotEmpty(t, mySql.Ip)
-	assert.NotEmpty(t, mySql.Port)
-	assert.NotEmpty(t, mySql.Username)
-	assert.NotEmpty(t, mySql.Password)
-	assert.NotEmpty(t, mySql.DbName)
-	assert.NotNil(t, mySql.Db)
-
-	err = mySql.Db.Ping()
+	assert.NotNil(t, mySql.GetDb())
+
+	dbInfo := mySql.GetDbInfo()
+
+	assert.NotEmpty(t, dbInfo.Ip)
+	assert.NotEmpty(t, dbInfo.Port)
+	assert.NotEmpty(t, dbInfo.Username)
+	assert.NotEmpty(t, dbInfo.Password)
+	assert.NotEmpty(t, dbInfo.DbName)
+
+	err = mySql.GetDb().Ping()
 
 	assert.Nil(t, err)
 }

mysqltestcontainer/info.go

@@ -0,0 +1,9 @@
+package mysqltestcontainer
+
+type DbInfo struct {
+	Username string
+	Password string
+	Ip       string
+	Port     string
+	DbName   string
+}

mysqltestcontainer/my_sql.go

@@ -3,10 +3,14 @@ package mysqltestcontainer
 import "database/sql"
 
 type MySql struct {
-	Db       *sql.DB
-	Username string
-	Password string
-	Ip       string
-	Port     string
-	DbName   string
+	db     *sql.DB
+	dbInfo *DbInfo
+}
+
+func (m *MySql) GetDb() *sql.DB {
+	return m.db
+}
+
+func (m *MySql) GetDbInfo() *DbInfo {
+	return m.dbInfo
 }