Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

front loaded is a valid budget_pacing for lifetime pacing period #372

Description

@jamiereinhard

https://github.com/shipyardapp/shipyard-blueprints/blob/8e6c4e602774b632f79329bc9ea5f728d4f5985b/shipyard_blueprints/magnite/shipyard_magnite/dataclasses/budget_item.py#L51C9-L54C11

example in a live campaign:

Image

it does require that there are flight dates set but I think we should remove the validation from here for now since we don't get the flight dates right - since we're just on budget updates and paused right now on development, having the validation of that might hamper us (since adding checking for the flight dates would take more time) - and if they don't have it selected it would error - mostly since these are set campaigns we should assume if its already front loaded it has a flight date set

even & front loaded are the same, they both require flight dates so I think removing the validation makes the most sense on this one

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions