Skip to content

Commit ed421a2

Browse files
committed
stringify appVersion and appBuildNumber
1 parent 19f6f8a commit ed421a2

File tree

5 files changed

+24
-25
lines changed

5 files changed

+24
-25
lines changed

package-lock.json

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@aptabase/react-native",
3-
"version": "0.3.0",
3+
"version": "0.3.1",
44
"private": false,
55
"description": "React Native SDK for Aptabase: Open Source, Privacy-First and Simple Analytics for Mobile, Desktop and Web Apps",
66
"sideEffects": false,

src/client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export class AptabaseClient {
1010
private readonly _env: EnvironmentInfo;
1111
private _sessionId = newSessionId();
1212
private _lastTouched = new Date();
13-
private _flushTimer: number | undefined;
13+
private _flushTimer: NodeJS.Timeout | undefined;
1414

1515
constructor(appKey: string, env: EnvironmentInfo, options?: AptabaseOptions) {
1616
const [_, region] = appKey.split("-");

src/env.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ export function getEnvironmentInfo(): EnvironmentInfo {
2020
const locale = "en-US";
2121

2222
return {
23-
appVersion: version.appVersion || "",
24-
appBuildNumber: version.appBuildNumber || "",
23+
appVersion: version.appVersion,
24+
appBuildNumber: version.appBuildNumber,
2525
isDebug: __DEV__,
2626
locale,
2727
osName,

src/version.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
1-
2-
import { NativeModules } from 'react-native';
1+
import { NativeModules } from "react-native";
32

43
const { RNAptabaseModule } = NativeModules;
54

65
type VersionObject = {
7-
appVersion: string | undefined,
8-
appBuildNumber: string | undefined,
6+
appVersion: string;
7+
appBuildNumber: string;
98
};
109

1110
const Version: VersionObject = {
12-
appVersion: RNAptabaseModule && RNAptabaseModule.appVersion,
13-
appBuildNumber: RNAptabaseModule && RNAptabaseModule.appBuildNumber,
11+
appVersion: RNAptabaseModule?.appVersion?.toString() ?? "",
12+
appBuildNumber: RNAptabaseModule?.appBuildNumber?.toString() ?? "",
1413
};
1514

16-
export default Version;
15+
export default Version;

0 commit comments

Comments
 (0)